#160617679 implement notifications functionality #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaabu
changed the title
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
6614929
to
678c1b6
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
678c1b6
to
af8560c
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
af8560c
to
92a7622
Compare
kimbugp
reviewed
Oct 19, 2018
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
92a7622
to
6baccf8
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
6baccf8
to
56a95d2
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
56a95d2
to
8b1a373
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
8b1a373
to
ff49a7c
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
ff49a7c
to
d81997c
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
d81997c
to
452897e
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
452897e
to
6dfaa47
Compare
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
6dfaa47
to
360311d
Compare
- create notitifcations app - setup folder structure - setup models [Delivers ##160617679] feat(create notifications): write tests for endpoints - write tests for retrieving all notififcations - write tests for opting in or out of notifications [Delivers ##160617679] feat(create notifications): setup comment notification functionality - setup comment notification model - setup comment notification serializer - setup comment notification views - implement tests for the views [Delivers ##160617679]
zaabu
force-pushed
the
ft-notifications-160617679
branch
from
360311d
to
c135931
Compare
PatrickCmd
approved these changes
Oct 22, 2018
PatrickCmd
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements notifications functionality into the application. This enables users to be able to receive notifications when users they follow publish new articles. This functionality also enables users to be able to receive notifications when articles they favorited have new interactions (like new comments).
Description of Task to be completed?
Notifications give users to opportunity to know what they may have missed which may be important to them.
Users should receive notifications when users they follow publish new articles.
Users should receive notifications when articles they favorited have new interactions (like new comments).
Users should be able to opt in and out of these notifications.
Endpoints
GET /api/notifications/all-- Get all notificationsGET /api/notifications/comments- Get all comment notificationsGET /api/notifications/articles- Get all articles notificationsGET /api/notifications/comments/<str:pk>- Get specific comment notificationGET /api/notifications/articles/<str:pk>- Get specific article notificationHow should this be manually tested?
-Follow a user, whenever they publish an article, you should be notified.
-Favorite an article, whenever a comment is made on it, you should be notified.
What are the relevant pivotal tracker stories?
[Delivers #160617679]