Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163383174 Add descriptive error messages on invalid login and registration data #18

Merged

Conversation

karuhanga
Copy link
Collaborator

@karuhanga karuhanga commented Feb 1, 2019

What does this PR do?

  • add an alphanumeric password validator
  • remove extra, unused checks for required fields in LoginSerializer
  • updated test data to reflect new validation conditions
  • added additional test data
  • added method to allow easy authentication for test requests
  • added test for updating a user's email address

Description of Task to be completed?

  • Users should receive a descriptive error message when they enter invalid user parameters in an attempt to signup.
  • The user will be successfully signed up if the data they provide is correct

How should this be manually tested?

  • Visit this PR's app and test the described changes

Any background context you want to provide?

  • Previous error messages were not sufficiently descriptive

What are the relevant pivotal tracker stories?

- add an alphanumeric password validator
- remove extra, unused checks for required fields in LoginSerializer
- updated test data to reflect new validation conditions
- added additional test data
- added method to allow easy authentication for test requests
- added test for updating a user's email address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants