#163383192 Add functionality to filter and search for articles #37
Conversation
There was a problem hiding this comment.
Work looks good, precise and on point but add a little more comments in your classes plus generally make function names more descriptive and precise. like I commented on certain lines I've added on my review.
Otherwise, great Job done @oma0256.
| self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
| self.assertEqual(len(response.data), 0) | ||
|
|
||
| def test_user_can_filter_by_articles_by_title(self): |
There was a problem hiding this comment.
Thanks for the good work done @oma0256. But think you want to do here is name this method as test_user_can_filter_articles_by_title.
Thanks.
| self.assertEqual(len(response.data), 0) | ||
|
|
||
| def test_user_can_filter_by_articles_by_tag(self): | ||
| """ |
There was a problem hiding this comment.
I think the same thing might apply here. its test_user_can_filter_articles_by_tag.
| @@ -84,18 +85,27 @@ | |||
| # Password validation | |||
| # https://docs.djangoproject.com/en/1.11/ref/settings/#auth-password-validators | |||
|
|
|||
| USER_ATTRIBUTE_SIMILARITY_VALIDATOR = \ | |||
There was a problem hiding this comment.
Thanks for the good work. If you don't mind me asking, what is the functionality of the lines below that were added in this file
There was a problem hiding this comment.
@missvicki I touched this file so they were pep8 issues I was just resolving those issues
There was a problem hiding this comment.
Alright, makes sense. You did a good job on this one
| }, | ||
| { | ||
| 'NAME': 'django.contrib.auth.password_validation.CommonPasswordValidator', | ||
| 'NAME': COMMON_PASSWORD_VALIDATOR, |
There was a problem hiding this comment.
@oma0256, good work here. Thanks. I see you have made some changes in the settings file. Do these two lines mean the same thing or some env variables need to be set in the env file?
There was a problem hiding this comment.
@pbkabali Yea they do mean the same thing I was just trying to avoid pep8 issues
oma0256
force-pushed
the
ft-filter-search-articles-163383192
branch
from
f0bfc5e
to
8fded8e
Compare
|
@oma0256 , please resolve the merge conflicts |
oma0256
force-pushed
the
ft-filter-search-articles-163383192
branch
from
8fded8e
to
698b4e5
Compare
…onality of articles - ensure users can filter articles based on author's username, article title, tags - ensure users can search fo articles based on keywords [Starts #163383192]
oma0256
force-pushed
the
ft-filter-search-articles-163383192
branch
from
698b4e5
to
b8dff4c
Compare
What does this PR do?
How should this be manually tested?
https://ah-backend-summer-stagin-pr-37.herokuapp.com/api/v1/articles/?<param>=<search_text><param> can be author, title, tag <search_text> the text you want to search or filter basing onto filter for articles orhttps://ah-backend-summer-stagin-pr-37.herokuapp.com/api/v1/articles/?search=<search_text>to search for articles usingGET.What are the relevant pivotal tracker stories?
#163383192