Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161255353 Validation errors #13

Merged
merged 4 commits into from
Nov 2, 2018
Merged

#161255353 Validation errors #13

merged 4 commits into from
Nov 2, 2018

Conversation

AnguleMathias
Copy link
Contributor

What does this PR do?

  • Users are able to receive descriptive signup/Registration email validation error

Description of Task to be completed

  • Users should receive descriptive error messages upon signing up with invalid user parameters
  • Invalid user parameters include:
    i. Existing user email
    ii. Invalid email
    iii. Password of length less than 8
    iv. Password not being alphanumeric

How should this be manually tested?

  • Run app by : python3 migrate.py runserver in terminal
  • Use postman on end-route: api/users/
  • Signup/Register user(s)

What are the relevant pivotal tracker stories?

AnguleMathias and others added 4 commits October 30, 2018 10:53
@AnguleMathias
Feature(Registration Validation Errors): Users should receive descrip…
26eccbb 
…tive signup/Registration validation errors

- Update email validation
- Update password validation
- Added test for empty password validation

[Feature #161255353]
@AnguleMathias
Feature(Registration Validation Errors): Users should receive descrip…
87a16b1 
…tive signup/Registration validation errors

- Update password validation not to accept repeating patterns more than twice

[Feature #161255353]
@AnguleMathias
Feature(Registration Validation Errors): Users should receive descrip…
2befbbb 
…tive signup/Registration validation errors

- Update password validation not to accept repeating patterns more than twice

[Feature #161255353]
@AnguleMathias
Merge branch 'develop' into ft-validation-errors-161255353
b225055
@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.168%
Totals Coverage Status
Change from base Build 66: 0.0%
Covered Lines: 168
Relevant Lines: 202
💛 - Coveralls

maxwellgithinji
maxwellgithinji approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@maxwellgithinji maxwellgithinji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

KITHU
KITHU approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@KITHU KITHU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnguleMathias AnguleMathias changed the title Ft validation errors 161255353 #161255353 Validation errors Nov 2, 2018
@AnguleMathias AnguleMathias temporarily deployed to ah-codeofduty-staging November 2, 2018 07:38 Inactive
njeri-ngigi
njeri-ngigi approved these changes Nov 2, 2018
View reviewed changes
Copy link
Collaborator

@njeri-ngigi njeri-ngigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meshnesh meshnesh merged commit edd8b79 into develop Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellgithinji maxwellgithinji maxwellgithinji approved these changes

@KITHU KITHU KITHU approved these changes

@njeri-ngigi njeri-ngigi njeri-ngigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AnguleMathias @coveralls @maxwellgithinji @KITHU @njeri-ngigi @meshnesh