#161255374 Highlight and Comment on any text in an article #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374]
meshnesh
requested review from
3N61N33R,
KITHU,
AnguleMathias and
maxwellgithinji
Pull Request Test Coverage Report for Build 271
💛 - Coveralls |
KITHU
approved these changes
Nov 14, 2018
3N61N33R
suggested changes
Nov 14, 2018
added 3 commits
November 14, 2018 15:33
…omments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374]
- Adjust code to match pep8 linting standards [Feature #161255374]
- Adjust code to match pep8 linting standards [Feature #161255374]
meshnesh
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Refactor tests [Feature #161255377]
meshnesh
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Feature(Article Reports): Users should be able to report an article - Added report to models - Added report method to comment serializer class - Added report endpoint - Tests for report funtionality [Feature #161255373] * Feature(Article Reports): Users should be able to report an article - Update .gitignore [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation [Feature #16125537] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Article Reports): Users should be able to report an article - Feedback implementation render data with article id [Feature #16125537] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * #161255377 Users should be able to like a specific comment (#29) * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Refactor tests [Feature #161255377] * Feature(Article Reports): Users should be able to report an article - Added report to models - Added report method to comment serializer class - Added report endpoint - Tests for report funtionality [Feature #161255373] * Feature(Article Reports): Users should be able to report an article - Update .gitignore [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation render data with article id [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Rebasing [Feature #16125537]
meshnesh
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Added articles like and dislikes to models - Addedlikes and dislikes to articles serializer class - Added articles like and dislikes endpoints - Tests for articles likes and dislikes functionality [Feature #161255362] * Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Added tests for articles likes and dislikes functionality [Feature #161255362] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Feedback implementation [Feature #161255362] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * #161255377 Users should be able to like a specific comment (#29) * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Refactor tests [Feature #161255377] * #161255373 Article Reports (#30) * Feature(Article Reports): Users should be able to report an article - Added report to models - Added report method to comment serializer class - Added report endpoint - Tests for report funtionality [Feature #161255373] * Feature(Article Reports): Users should be able to report an article - Update .gitignore [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation [Feature #16125537] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Article Reports): Users should be able to report an article - Feedback implementation render data with article id [Feature #16125537] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * #161255377 Users should be able to like a specific comment (#29) * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * #161255376 comment track edit history (#32) * Feature(track comment history):Comments should be able to track edit history - added CommentHistory model - modified comment update to store history [Feature #161255376] * Feature(track comment history):Comments should be able to track edit history - remove debug statements - add docstrings [Feature #161255376] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * #161255369 Add Search Functionality and Custom filtering based on parameters (#28) * feature(search_filter): search, filter functionality -add app search and filter functionality [feature #161255369] * feature(search_filter): search, filter functionality -fix list articles bug -add doctstrings [feature #161255369] * feature(filter_search): filter, search functionality -add docstrings -remove repeated classes [feature #161255369] * #161255374 Highlight and Comment on any text in an article (#31) * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(Highlight and comment on text): Add CRUD for highlights and comments on text - Add CRUD functions for higlighting and commenting on any text of an article - Add tests for these CRUD functions [Feature #161255374] * Feature(#161255374 Highlighting and commenting on text): Lint code - Adjust code to match pep8 linting standards [Feature #161255374] * #161255370 Users should be able to see the time it takes to read an article (#34) * Feature(#161255370 Time to read): Calculate time to read - Add method to calculate time to read an article - Add test for calculating time to read an article [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * Feature(#161255370 Time to read): Lint code - Adjust code to match pep8 linting standards [Feature #161255370] * #161255368 Pagination support for articles (#35) * feature(pagination): pagination for articles -enable pagination for articles [feature #161255368] * feature(pagination): article pagination functionality -override pagination response -fix search and filter functionality - resolve merge conflicts [feature #161255368] * feature(pagination): article pagination functionality -remove import error [feature #161255368] * feature(pagination): article pagination functionality -fix tests [feature #161255368] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models - Added comment-likes and comment-dislikes method to comment serializer class - Automatic updates to migrations - Deleted .DS_Store [Feature #161255377] * Feature(Comment likes):Users should be able to like/dislike comments to articles - Added comment-likes and comment_dislikes fields to models tests - Update comment-likes and comment-dislikes method to comment serializer class - Updates to migrations [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Feedback implementation [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Rebase commit [Feature #161255377] * Feature(Comment likes):Users should be able to like comments to articles - Refactor tests [Feature #161255377] * Feature(Article Reports): Users should be able to report an article - Added report to models - Added report method to comment serializer class - Added report endpoint - Tests for report funtionality [Feature #161255373] * Feature(Article Reports): Users should be able to report an article - Update .gitignore [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Feedback implementation render data with article id [Feature #16125537] * Feature(Article Reports): Users should be able to report an article - Rebasing [Feature #16125537] * Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Added articles like and dislikes to models - Addedlikes and dislikes to articles serializer class - Added articles like and dislikes endpoints - Tests for articles likes and dislikes functionality [Feature #161255362] * Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Added tests for articles likes and dislikes functionality [Feature #161255362] * Feature(Article Likes and Dislikes): Users should be able to like or dislike an article - Feedback implementation [Feature #161255362]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Endpoints involved:
How to manually test these features
Description of tasks to be completed
As a user i should be able to highlight any text in an article(created by me or not) and comment on it.
What are the relevant pivotal tracker stories?
#161255374 Users should be able to highlight and comment on any text in an article
Screenshots