#167190438 User's Profile #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hadeneekeh
requested review from
Lundii,
chuxmykel,
cvjude,
chiboycalix,
encodedBicoding,
obayomi96 and
topseySuave
and removed request for
Lundii and
chuxmykel
chuxmykel
reviewed
Jul 30, 2019
chiboycalix
force-pushed
the
ft/167190438/create-user-profile
branch
from
95bbe1d
to
0e406d7
Compare
Get user's profille Updates #167190438
get any user's profile [Finishes #167190438]
improve test [Updates #167190438]
edit user's profile [Finishes #167190438]
edit user's profile [Finishes #167190438]
fix merge conflict [Delivers #167190438]
fix merge conflict [Delivers #167190438]
Improve implementation and add validation [Delivers #167190438]
Improve implementation and add validation [Delivers #167190438]
Hadeneekeh
force-pushed
the
ft/167190438/create-user-profile
branch
from
0e406d7
to
4a5df33
Compare
Fix failing test [Delivers #167190438]
topseySuave
approved these changes
Aug 1, 2019
|
Please next time try to reduce the amount similar commits you make |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GET /api/userwhich creates the user's profilePUT /api/userwhich edits the user's profileGET /api/profiles/:usernamewhich has viewing another user's profileDescription of Task to be completed?
How should this be manually tested?
ft/167190438/create-user-profileAny background context you want to provide?
'image'as the key for the image upload.What are the relevant pivotal tracker stories?
#167190438
Screenshots (if appropriate)
Questions:
NA