#167190450 Implement pagination for Articles #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiboycalix
requested review from
topseySuave,
Lundii,
encodedBicoding,
obayomi96,
chuxmykel,
cvjude and
Hadeneekeh
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
15af4ac
to
26d70eb
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
26d70eb
to
fab9f9e
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
fab9f9e
to
e6e626d
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
e6e626d
to
953329e
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
953329e
to
e48a1b9
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
e48a1b9
to
03718a0
Compare
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
03718a0
to
c95fe4f
Compare
chuxmykel
approved these changes
Aug 5, 2019
| page = parseInt(page, 10) > 0 ? page : 1; | ||
| const offset = (page - 1) * limit; | ||
| const articles = await models.Article.findAndCountAll({ | ||
| where: {}, |
There was a problem hiding this comment.
I'm curious bro. Is there any reason why you specified an empty where constraint?
There was a problem hiding this comment.
Thank you very much for that question. The reason is that am not supposed to filter the returned article by any condition. If the story, for instance, required that I paginate the article and return articles that belong to a particular author, then I can include a condition in the where object. (e.g where: {authorId: req.user.id), then this will return only articles created by an author with the specified authorId.
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
3 times, most recently
from
4aa89c3
to
de421fd
Compare
- setup pagination for articles - write controller functions to handle pagination - write unit test [finishes #167190450]
chiboycalix
force-pushed
the
ft/articles-pagination-167190450
branch
from
de421fd
to
c2d8ab9
Compare
topseySuave
approved these changes
Aug 6, 2019
chiboycalix
pushed a commit
that referenced
this pull request
Aug 6, 2019
#167190450 Implement pagination for Articles
chiboycalix
pushed a commit
that referenced
this pull request
Aug 6, 2019
#167190450 Implement pagination for Articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#167190450
Screenshots (if appropriate)
Questions: