Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167190453 Implement read time for articles #27

Merged
merged 2 commits into from
Aug 8, 2019
Merged

#167190453 Implement read time for articles #27

merged 2 commits into from
Aug 8, 2019

Conversation

cvjude
Copy link
Contributor

@cvjude cvjude commented Aug 6, 2019

What does this PR do?

  • Allows users to see the amount of time it takes to read an article

Description of the task to be completed

Add new read time column to the article table
Implement article read time by averaging 200 words in a minute
Modify the create article endpoint to return the article read time

How can this be manually tested?

  • Clone the repo
  • Run the command below in your terminal to install all dependencies
npm install
  • Run the command below to test
npm test

Any background context you want to provide?

none

What are the relevant Pivotal Tracker stories?

@cvjude cvjude added the Please review me Needs review label Aug 6, 2019
chuxmykel
chuxmykel approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@chuxmykel chuxmykel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏾

@cvjude cvjude force-pushed the ft/167190453-implement-article-read-time branch from be33c3a to 1732861 Compare August 6, 2019 10:08
Hadeneekeh
Hadeneekeh approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@Hadeneekeh Hadeneekeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chiboycalix
chiboycalix approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@chiboycalix chiboycalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lundii
Lundii approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@Lundii Lundii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvjude cvjude added Ready to be merged and removed Please review me Needs review labels Aug 6, 2019
@topseySuave @cvjude
Merge pull request #24 from andela/ft/167190440-article-crud
8a677c0 
#167190440 Attach authors to articles created by them
@cvjude cvjude force-pushed the ft/167190453-implement-article-read-time branch from 1732861 to 8a677c0 Compare August 7, 2019 15:36
@cvjude cvjude force-pushed the ft/167190453-implement-article-read-time branch from 959b3cd to b1ff6cb Compare August 8, 2019 12:11
@topseySuave topseySuave merged commit 5e9d4b9 into develop Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topseySuave topseySuave topseySuave approved these changes

@chiboycalix chiboycalix chiboycalix approved these changes

@Lundii Lundii Lundii approved these changes

@chuxmykel chuxmykel chuxmykel approved these changes

@Hadeneekeh Hadeneekeh Hadeneekeh approved these changes

@encodedBicoding encodedBicoding Awaiting requested review from encodedBicoding

@obayomi96 obayomi96 Awaiting requested review from obayomi96

Assignees
No one assigned
Labels
Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cvjude @topseySuave @chiboycalix @Lundii @encodedBicoding @chuxmykel @Hadeneekeh