-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
167190463 User can highlight an article text and make a comment #37
Merged
topseySuave
merged 1 commit into
develop
from
ft/167190463-highligt-article-text-comment
Aug 9, 2019
Merged
167190463 User can highlight an article text and make a comment #37
topseySuave
merged 1 commit into
develop
from
ft/167190463-highligt-article-text-comment
Aug 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvjude
force-pushed
the
ft/167190463-highligt-article-text-comment
branch
from
August 8, 2019 09:18
cec25be
to
56276f9
Compare
cvjude
requested review from
chiboycalix,
encodedBicoding,
chuxmykel,
Hadeneekeh,
Lundii,
obayomi96 and
topseySuave
and removed request for
chiboycalix and
encodedBicoding
August 8, 2019 09:19
topseySuave
approved these changes
Aug 8, 2019
obayomi96
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lundii
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cvjude
force-pushed
the
ft/167190463-highligt-article-text-comment
branch
3 times, most recently
from
August 8, 2019 19:51
a712898
to
f801b7c
Compare
Implement algorithm to highlight article text Write unit texts write controller to allow user to comment on the article get all the comment on a highlight [Delivers #167190463]
cvjude
force-pushed
the
ft/167190463-highligt-article-text-comment
branch
from
August 9, 2019 03:49
f801b7c
to
ed2cd5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of the task to be completed
How can this be manually tested?
Any background context you want to provide?
none
What are the relevant Pivotal Tracker stories?