Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

167190463 User can highlight an article text and make a comment #37

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

cvjude
Copy link
Contributor

@cvjude cvjude commented Aug 8, 2019

What does this PR do?

  • Should allow a user to highlight an article text and make a comment

Description of the task to be completed

Implement algorithm to highlight article text
Write unit tests
Write controller to allow the user to comment on the article
Get all the comment on a highlight

How can this be manually tested?

  • Clone the repo
  • Run the command below in your terminal to install all dependencies
npm install
  • Run the command below to test
npm test

Any background context you want to provide?

none

What are the relevant Pivotal Tracker stories?

@cvjude cvjude force-pushed the ft/167190463-highligt-article-text-comment branch from cec25be to 56276f9 Compare August 8, 2019 09:18
@cvjude cvjude added the Please review me Needs review label Aug 8, 2019
Copy link
Contributor

@obayomi96 obayomi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Lundii Lundii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/routes/comment.js Outdated Show resolved Hide resolved
server/routes/article.js Outdated Show resolved Hide resolved
server/middlewares/schema.js Outdated Show resolved Hide resolved
server/middlewares/inputValidator.js Outdated Show resolved Hide resolved
server/middlewares/inputValidator.js Outdated Show resolved Hide resolved
server/middlewares/inputValidator.js Outdated Show resolved Hide resolved
@cvjude cvjude force-pushed the ft/167190463-highligt-article-text-comment branch 3 times, most recently from a712898 to f801b7c Compare August 8, 2019 19:51
@chuxmykel chuxmykel temporarily deployed to a-haven-staging-pr-37 August 8, 2019 19:51 Inactive
Implement algorithm to highlight article text
Write unit texts
write controller to allow user to comment on the article
get all the comment on a highlight

[Delivers #167190463]
@topseySuave topseySuave merged commit 4b27928 into develop Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants