Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168288749 fix pagination endpoint #55

Merged
merged 1 commit into from
Sep 4, 2019
Merged

#168288749 fix pagination endpoint #55

merged 1 commit into from
Sep 4, 2019

Conversation

cvjude
Copy link
Contributor

@cvjude cvjude commented Sep 4, 2019

What does this PR do?

  • fix pagination endpoint

Description of the task to be completed

Modify the pagination helper to receive external models

How can this be manually tested?

  • Clone the repo
  • Run the command below in your terminal to install all dependencies
npm install
  • Run the command below to test
npm test

Any background context you want to provide?

none

What are the relevant Pivotal Tracker stories?

@cvjude
Bug(Pagination): fix pagination endpoint
b8e23ea 
Modify the pagination helper to recieve extrenal models

[Fixes #168288749]
@obayomi96 obayomi96 assigned obayomi96 and unassigned obayomi96 Sep 4, 2019
@obayomi96 obayomi96 self-requested a review September 4, 2019 14:55
obayomi96
obayomi96 approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@obayomi96 obayomi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chuxmykel
chuxmykel approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@chuxmykel chuxmykel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jude. Looks good to me.

@Hadeneekeh Hadeneekeh self-requested a review September 4, 2019 17:53
@topseySuave topseySuave merged commit dff4d76 into develop Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topseySuave topseySuave topseySuave approved these changes

@obayomi96 obayomi96 obayomi96 approved these changes

@chuxmykel chuxmykel chuxmykel approved these changes

@Hadeneekeh Hadeneekeh Hadeneekeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cvjude @topseySuave @obayomi96 @chuxmykel @Hadeneekeh