Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168456837 Users can recieve follow notifications #61

Merged
merged 1 commit into from
Sep 12, 2019
Merged

#168456837 Users can recieve follow notifications #61

merged 1 commit into from
Sep 12, 2019

Conversation

cvjude
Copy link
Contributor

@cvjude cvjude commented Sep 12, 2019

What does this PR do?

  • Users can receive follow notifications

Description of the task to be completed

Modify the user controller to alert the user when followed, or unfollowed

How can this be manually tested?

  • Clone the repo
  • Run the command below in your terminal to install all dependencies
npm install
  • Run the command below to test
npm test

Any background context you want to provide?

none

What are the relevant Pivotal Tracker stories?

Hadeneekeh
Hadeneekeh approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@Hadeneekeh Hadeneekeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lundii
Lundii approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@Lundii Lundii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvjude
feat(Notify): Users can recieve follow notifications
1c99442 
- Modify the userController to alert user on follow notification

[Delivers ##168456837]
@cvjude cvjude force-pushed the ft/168456837-user-recieve-follow-notification branch from 925a102 to 1c99442 Compare September 12, 2019 15:46
chuxmykel
chuxmykel approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@chuxmykel chuxmykel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good @cvjude. Nice work

@chiboycalix chiboycalix self-requested a review September 12, 2019 17:49
chiboycalix
chiboycalix approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@chiboycalix chiboycalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obayomi96 obayomi96 self-requested a review September 12, 2019 17:50
obayomi96
obayomi96 approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@obayomi96 obayomi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuxmykel chuxmykel merged commit bc9868c into develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiboycalix chiboycalix chiboycalix approved these changes

@Lundii Lundii Lundii approved these changes

@obayomi96 obayomi96 obayomi96 approved these changes

@chuxmykel chuxmykel chuxmykel approved these changes

@Hadeneekeh Hadeneekeh Hadeneekeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cvjude @chiboycalix @Lundii @obayomi96 @chuxmykel @Hadeneekeh