Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#168380301 Fixes .env variables on production #27

Merged
merged 4 commits into from
Sep 10, 2019
Merged

#168380301 Fixes .env variables on production #27

merged 4 commits into from
Sep 10, 2019

Conversation

encodedBicoding
Copy link
Contributor

What does this PR do?

  • Fixes env variables on production
  • ensure Heroku is able to see our env variables

Description of Task to be completed?

  • Upgrades Webpack config to use env variables

How should this be manually tested?

  • Use the review app

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#168380301

Screenshots (if appropriate)

N/A

Questions:

N/A

@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 16:37 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 16:42 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 16:51 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 16:55 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 16:59 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:04 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:11 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:16 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:23 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:31 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:38 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 17:54 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 18:01 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 18:05 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 18:18 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 18:24 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 9, 2019 18:28 Inactive
Hadeneekeh
Hadeneekeh approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@Hadeneekeh Hadeneekeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chiboycalix chiboycalix self-requested a review September 10, 2019 09:42
chiboycalix
chiboycalix approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@chiboycalix chiboycalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 10, 2019 11:33 Inactive
@chuxmykel chuxmykel temporarily deployed to ah-commando-react-pr-27 September 10, 2019 11:51 Inactive
obayomi96
obayomi96 approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@obayomi96 obayomi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lundii
Lundii approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@Lundii Lundii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chuxmykel
chuxmykel approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@chuxmykel chuxmykel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Works well. Looks good to me.

@topseySuave topseySuave merged commit 0cded7e into develop Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topseySuave topseySuave topseySuave approved these changes

@chiboycalix chiboycalix chiboycalix approved these changes

@Lundii Lundii Lundii approved these changes

@obayomi96 obayomi96 obayomi96 approved these changes

@chuxmykel chuxmykel chuxmykel approved these changes

@Hadeneekeh Hadeneekeh Hadeneekeh approved these changes

@cvjude cvjude Awaiting requested review from cvjude

Assignees
No one assigned
Labels
Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@encodedBicoding @topseySuave @chiboycalix @Lundii @obayomi96 @chuxmykel @Hadeneekeh