#163499467 Save article draft #32

MaggieChege · 2019-01-31T16:23:51Z

What does this PR do?

A user can create an article draft.
A user can publish the article later.
A user can view all the drafts he/she has.

Description of Task to be completed?

A user can create an article draft and publish it later.

How should this be manually tested?
Clone the repo locally

cd ah-django-unchained

git checkout ft-save-article-draft-163499467

get started with the app as from the README section. Follow the sample .env file supplied to obtain the right variables

SCREENSHOTS

Create an article draft

Get all drafts

Publish Article

kwameasiago · 2019-01-31T19:00:47Z

authors/apps/articles/views.py

+    serializer_class = PublishArticleSerializer
+    lookup_field = 'slug'
+
+
 class DeleteArticle(UpdateAPIView):


Add a class comment

d-kahara

Looks good to me

ignatiusukwuoma · 2019-02-01T10:13:17Z

authors/apps/articles/models.py

@@ -19,6 +19,10 @@ class Article(models.Model):
    is_published = models.BooleanField(default=False)
    favorite = models.ManyToManyField(
        User, related_name='favorite', default=False)
+
+    favorite = models.ManyToManyField(User, related_name='favorite',


favorites is duplicated

ignatiusukwuoma

See these

ignatiusukwuoma · 2019-02-01T10:24:04Z

authors/apps/articles/serializers.py

        thread_comment = super(
            CommentSerializer, self).to_representation(instance)
+
+        thread_comment = super(CommentSerializer, self).to_representation(


ignatiusukwuoma · 2019-02-01T10:26:48Z

authors/apps/articles/urls.py

-                    LikeCommentApiView, DislikeCommentApiView
+                    LikeCommentApiView, DislikeCommentApiView,
+                    ReadTime, PublishArticle, GetDraft,
+                     PublishArticle, GetDraft


Duplicate imports

ignatiusukwuoma · 2019-02-01T10:28:19Z

authors/apps/articles/urls.py

@@ -58,4 +60,10 @@
         LikeCommentApiView.as_view(), name='comment_like'),
    path('articles/<slug>/comments/<int:id>/dislike',
         DislikeCommentApiView.as_view(), name='comment_dislike'), 
+
+    path('article/<slug>/publish/',


articles/

ignatiusukwuoma · 2019-02-01T10:43:03Z

authors/apps/articles/views.py

+class GetDraft(ListAPIView):
+    """Get all Drafts"""
+    pagination_class = CustomPagination
+    permission_classes = (IsAuthorOrReadOnly,)


I'll still be able to see drafts of other authors

ignatiusukwuoma · 2019-02-01T10:48:40Z

authors/apps/articles/views.py

+    permission_classes = (IsAuthorOrReadOnly,)
+    queryset = Article.objects.filter(is_deleted=False, is_published=False)
+    serializer_class = PublishArticleSerializer
+    lookup_field = 'slug'


Let's return the published article

ignatiusukwuoma · 2019-02-02T13:28:20Z

authors/apps/articles/tests/test_create_article.py

        self.create_article(self.create_article_data, token)
        self.create_article(self.create_article_data2, token)
+        # publish articles
+        self.client.put(reverse('articles:publish_article',


Assert the value of is_published is as expected before and after publishing

ignatiusukwuoma · 2019-02-02T13:29:09Z

authors/apps/articles/tests/test_create_article.py

        token = self.signup_user_one()
        del self.create_article_data['images']
        response = self.client.post(self.article_listcreate,
                                    self.create_article_data,
                                    format='json',
-                                    HTTP_AUTHORIZATION='token {}'.format(token))
+                                    HTTP_AUTHORIZATION='token {}'.format(
+                                        token))


Also assert the value of is_published, that's what makes it a draft

ignatiusukwuoma · 2019-02-02T13:34:52Z

authors/apps/articles/urls.py

+    path('article/<slug>/publish/',
+         PublishArticle.as_view(),
+         name="publish_article"),
+    path('article/draft/', GetDraft.as_view(),


articles/drafts/

ignatiusukwuoma · 2019-02-02T14:48:36Z

authors/apps/articles/tests/test_create_article.py

        response = self.client.get(self.article_listcreate, format='json')
        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(response.data['results'][0]['is_published'], True)


ignatiusukwuoma · 2019-02-02T14:48:56Z

authors/apps/articles/tests/test_create_article.py

        self.create_article(self.create_article_data, token)
        self.create_article(self.create_article_data2, token)
+        # publish articles
+        self.assertNotEqual(self.create_article_data['is_published'], True)


assertFalse

ignatiusukwuoma · 2019-02-02T17:21:08Z

authors/apps/articles/views.py

+class GetDraft(ListAPIView):
+    """Get all Drafts"""
+    pagination_class = CustomPagination
+    permission_classes = (IsAuthenticated,)


You can create an isAuthor class for this... so only an author can see his drafts

- Allow user to create a draft - Allow user to publish [Delivers #162948852]

Change urls change permissions

MaggieChege changed the title ~~#163499467save article draft~~ #163499467 . save article draft Jan 31, 2019

MaggieChege changed the title ~~#163499467 . save article draft~~ #163499467 save article draft Jan 31, 2019

MaggieChege changed the title ~~#163499467 save article draft~~ #163499467 Save article draft Jan 31, 2019

MaggieChege requested review from KMaina, kwameasiago and d-kahara January 31, 2019 18:18

kwameasiago reviewed Jan 31, 2019

View reviewed changes

MaggieChege force-pushed the ft-save-article-draft-163499467 branch from ca1a446 to 480d17b Compare February 1, 2019 06:21

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 1, 2019 06:21 Inactive

d-kahara approved these changes Feb 1, 2019

View reviewed changes

kwameasiago approved these changes Feb 1, 2019

View reviewed changes

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 1, 2019 07:28 Inactive

ignatiusukwuoma reviewed Feb 1, 2019

View reviewed changes

MaggieChege force-pushed the ft-save-article-draft-163499467 branch from 50a040d to c07e506 Compare February 1, 2019 10:18

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 1, 2019 10:19 Inactive

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 1, 2019 10:21 Inactive

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 1, 2019 10:22 Inactive

ignatiusukwuoma reviewed Feb 2, 2019

View reviewed changes

MaggieChege force-pushed the ft-save-article-draft-163499467 branch from f695003 to 234b92c Compare February 2, 2019 13:46

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 2, 2019 13:46 Inactive

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 2, 2019 14:33 Inactive

ignatiusukwuoma reviewed Feb 2, 2019

View reviewed changes

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 2, 2019 15:29 Inactive

ignatiusukwuoma reviewed Feb 2, 2019

View reviewed changes

Margaret Chege added 2 commits February 3, 2019 17:03

Save article as draft

7a439af

feature(Save article as draft):

530a9e1

- Allow user to create a draft - Allow user to publish [Delivers #162948852]

Margaret Chege added 8 commits February 3, 2019 17:03

Make changes

b8b8cee

Make changes

bdc96e1

Add comment on delete article

4568404

Add test to get all draft articles

98f7d77

Resolve conflict

c128380

Remove duplicate

9b8d924

Add assertion tests

e6ad2ee

Change urls change permissions

Change assert test

7e5c503

MaggieChege force-pushed the ft-save-article-draft-163499467 branch from cc2a96f to 7e5c503 Compare February 3, 2019 14:07

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 3, 2019 14:07 Inactive

Remove conflict

fb5dc4d

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 3, 2019 14:31 Inactive

Author can only view his own draft articles

f22c0d0

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 3, 2019 15:37 Inactive

Add requirements

7d0a650

d-kahara temporarily deployed to ah-django-unchained-stag-pr-32 February 3, 2019 15:48 Inactive

Add comment for author can only view his own drafts

aef47b9

d-kahara deployed to ah-django-unchained-stag-pr-32 February 3, 2019 15:56 View deployment

ignatiusukwuoma approved these changes Feb 3, 2019

View reviewed changes

ignatiusukwuoma merged commit acf9f9b into master Feb 3, 2019

ignatiusukwuoma deleted the ft-save-article-draft-163499467 branch February 3, 2019 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#163499467 Save article draft #32

#163499467 Save article draft #32

MaggieChege commented Jan 31, 2019

kwameasiago Jan 31, 2019

d-kahara left a comment

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma left a comment •

edited

Loading

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma Feb 1, 2019

ignatiusukwuoma Feb 2, 2019

ignatiusukwuoma Feb 2, 2019

ignatiusukwuoma Feb 2, 2019

ignatiusukwuoma Feb 2, 2019

ignatiusukwuoma Feb 2, 2019

ignatiusukwuoma Feb 2, 2019

#163499467 Save article draft #32

#163499467 Save article draft #32

Conversation

MaggieChege commented Jan 31, 2019

Choose a reason for hiding this comment

d-kahara left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignatiusukwuoma left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ignatiusukwuoma left a comment •

edited

Loading