#165273526: Password reset enhancement #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 14, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
The configured stylelint version is not supported.
The configured stylelint version is not supported. See a list of supported versions on our docs page.
| }; | ||
| /** | ||
| * This is a reducer for confirming a user's email address | ||
| * @param {object} |
There was a problem hiding this comment.
Expected JSDoc for 'state' but found 'object' valid-jsdoc
Missing JSDoc parameter type for 'object' valid-jsdoc
| passwordErrors: [], | ||
| tokenErrors: [], | ||
| }; | ||
| /** |
There was a problem hiding this comment.
Missing JSDoc for parameter 'action' valid-jsdoc
Missing JSDoc return description valid-jsdoc
| const newState = passwordResetReducer(undefined, { type: PASSWORD_RESET_FAILURE }); | ||
| expect(newState.isLoading).toBe(false); | ||
| expect(newState.isPassordResetSuccess).toBe(false); | ||
| expect(newState.isPasswordResetError).toBe(true); |
| it('Should have failed', () => { | ||
| const newState = passwordResetReducer(undefined, { type: PASSWORD_RESET_FAILURE }); | ||
| expect(newState.isLoading).toBe(false); | ||
| expect(newState.isPassordResetSuccess).toBe(false); |
|
|
||
| it('Should have failed', () => { | ||
| const newState = passwordResetReducer(undefined, { type: PASSWORD_RESET_FAILURE }); | ||
| expect(newState.isLoading).toBe(false); |
| const newState = passwordResetReducer(undefined, {}); | ||
| expect(newState.isLoading).toBe(false); | ||
| expect(newState.isPassordResetSuccess).toBe(false); | ||
| expect(newState.isPasswordResetError).toBe(false); |
| it('Should return the initial state', () => { | ||
| const newState = passwordResetReducer(undefined, {}); | ||
| expect(newState.isLoading).toBe(false); | ||
| expect(newState.isPassordResetSuccess).toBe(false); |
| describe('cpassowd reset Reducer', () => { | ||
| it('Should return the initial state', () => { | ||
| const newState = passwordResetReducer(undefined, {}); | ||
| expect(newState.isLoading).toBe(false); |
| }; | ||
| /** | ||
| * This is a reducer for confirming a user's email address | ||
| * @param {object} |
There was a problem hiding this comment.
Expected JSDoc for 'state' but found 'object' valid-jsdoc
Missing JSDoc parameter type for 'object' valid-jsdoc
| isConfirmEmailSuccess: false, | ||
| isConfirmEmailError: false, | ||
| }; | ||
| /** |
There was a problem hiding this comment.
Missing JSDoc for parameter 'action' valid-jsdoc
Missing JSDoc return description valid-jsdoc
• Created an email confirmation form
• Created a password reset form
[Finishes #165273526]
bisonlou
force-pushed
the
feature-password-reset-165273526
branch
from
598eaca
to
d4fc0fa
Compare
houndci-bot
reviewed
Jun 14, 2019
| const store = mockStore(initialState); | ||
|
|
||
| const wrapper = mount( | ||
| <MemoryRouter> |
llwasampijja
approved these changes
Jun 18, 2019
nadralia
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
• Redirects to the landing page on the successful reset of the password.
• Adds a success toast on the successful reset of the password.
Description of Task to be completed?
• A user should be able to reset their password in case they forget it.
• As long as a user can confirm their password, they should be able to reset their password.
How should this be manually tested?
Check out the preview app
Any background context you want to provide?
• Users should not have to create a new account once they lose their credentials.
What are the relevant pivotal tracker stories?
165273526
Screenshots (if appropriate)
