#164798256 Enable users manipulate articles #15

patrickf949 · 2019-05-14T11:20:42Z

What does this PR do?

Enables users to create and read articles

Description of Task to be completed?

Add routes for article creation and viewing
Create pages that users will interact with to create or read stories

How should this be manually tested?

Setup the application as stated here

Create and verify a user - here

Create articles with the following routes

localhost:8000/create-article --Simulated here

View articles on the landing page and click on them to get the full article --Simulated here

What are the relevant pivotal tracker stories?

164798256

Screenshots

Create an article

View all articles

src/reducers/createArticleReducer.js

src/styles/singleArticle.scss

houndci-bot · 2019-05-14T11:20:51Z

src/styles/singleArticle.scss

@@ -0,0 +1,25 @@
+.article-title {
+  font-size: 40px;


Properties should be ordered color, font-size, text-align

src/styles/createArticles.scss

houndci-bot · 2019-05-14T11:20:51Z

src/styles/createArticles.scss

+  .btn-primary {
+    color: #fff;
+    background-color: #003153;
+    border-color: #003153;


Color literals like #003153 should only be used in variable declarations; they should be referred to via variable everywhere else.

houndci-bot · 2019-05-14T11:20:51Z

src/styles/createArticles.scss

+  }
+  .btn-primary {
+    color: #fff;
+    background-color: #003153;


Color literals like #003153 should only be used in variable declarations; they should be referred to via variable everywhere else.

src/styles/navbar.scss

src/styles/createArticles.scss

src/components/navbar.js

src/components/articles/singleArticle.js

src/components/articles/createArticleComponent.js

src/components/articles/editArticlePage.js

src/components/articles/createArticlePage.js

src/actions/articleCreateEditAction.js

src/styles/app.scss

src/components/articles/userArticles.js

src/firebase/config.js

e-ian · 2019-05-20T07:57:59Z

src/components/articles/createArticlePage.js

+  }
+  onSubmit(e) {
+    e.preventDefault();
+    const messageObject = {


@patrickf949 you could do well with destructuring this.

good work with destructuring

Thanks @e-ian

e-ian · 2019-05-21T12:53:49Z

src/actions/LoginAction.js

@@ -23,7 +23,10 @@ export const userLoginRequest = userData => async dispatch => {

    sessionStorage.setItem("token", response.data.user.token);
    sessionStorage.setItem("username", response.data.user.username);
+    sessionStorage.setItem("email", response.data.user.email);


@patrickf949 why are we storing the email in session here.

@e-ian, the email is the most unique way of identifying a user, and that's what we are basing on in the backend to filter user articles

Okay but the username is equally unique in our backend.

anyatibrian

GREAT WORK @patrickf949

e-ian

LGTM

Genza999

Great work @patrickf949 .

MuhanguziDavid

Great implementation of the articles creation and retrieval. However, the retrieval of articles for a specific user is not working if one is logged in using social auth. This could be because the email is not saved in session storage on social login success. You may need to add it in the social auth action.

- add routes for article creation and viewing - add necessary pages for article creation and viewing - write tests for all functionality [Finishes #164798256]

patrickf949 · 2019-05-21T16:00:44Z

Great implementation of the articles creation and retrieval. However, the retrieval of articles for a specific user is not working if one is logged in using social auth. This could be because the email is not saved in session storage on social login success. You may need to add it in the social auth action.

Thanks @MuhanguziDavid all done

MuhanguziDavid

LGTM

houndci-bot reviewed May 14, 2019

View reviewed changes

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 14, 2019 11:20 Inactive

patrickf949 added the work in progress label May 14, 2019

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 4a35042 to 11f7e97 Compare May 14, 2019 11:52

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 14, 2019 11:52 Inactive

houndci-bot reviewed May 14, 2019

View reviewed changes

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 11f7e97 to 5d2603e Compare May 14, 2019 11:59

houndci-bot reviewed May 14, 2019

View reviewed changes

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 14, 2019 12:00 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 5d2603e to c891391 Compare May 14, 2019 12:30

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 14, 2019 12:30 Inactive

houndci-bot reviewed May 14, 2019

View reviewed changes

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from c891391 to 7e88fcb Compare May 14, 2019 16:04

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 14, 2019 16:04 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 7e88fcb to 8bd7cfb Compare May 15, 2019 23:19

houndci-bot reviewed May 15, 2019

View reviewed changes

src/components/articles/editArticlePage.js Outdated Show resolved Hide resolved

src/components/articles/createArticlePage.js Show resolved Hide resolved

src/actions/articleCreateEditAction.js Show resolved Hide resolved

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 15, 2019 23:20 Inactive

houndci-bot reviewed May 15, 2019

View reviewed changes

src/styles/app.scss Show resolved Hide resolved

src/components/articles/userArticles.js Show resolved Hide resolved

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 8bd7cfb to 0b4bf56 Compare May 16, 2019 07:47

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 16, 2019 07:47 Inactive

houndci-bot reviewed May 16, 2019

View reviewed changes

src/firebase/config.js Show resolved Hide resolved

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 0b4bf56 to 569f4a7 Compare May 16, 2019 13:41

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 16, 2019 13:41 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 569f4a7 to 9f31611 Compare May 17, 2019 05:02

patrickf949 had a problem deploying to ah-frontend-prime-pr-15 May 17, 2019 05:02 Failure

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch 2 times, most recently from f8bd879 to 77dc529 Compare May 17, 2019 09:03

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 17, 2019 09:03 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 77dc529 to d55b4fc Compare May 17, 2019 09:22

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 17, 2019 09:22 Inactive

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 20, 2019 16:58 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 23c726f to 50ac036 Compare May 20, 2019 17:22

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 20, 2019 17:22 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 50ac036 to 5b5e43f Compare May 20, 2019 17:42

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 20, 2019 17:42 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 5b5e43f to dee5d73 Compare May 20, 2019 18:16

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 20, 2019 18:16 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from dee5d73 to a4edaae Compare May 21, 2019 10:26

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 21, 2019 10:27 Inactive

patrickf949 added review ready and removed work in progress labels May 21, 2019

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from a4edaae to 17726c8 Compare May 21, 2019 12:40

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 21, 2019 12:40 Inactive

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 17726c8 to eb00933 Compare May 21, 2019 12:40

e-ian reviewed May 21, 2019

View reviewed changes

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from eb00933 to 213ee2d Compare May 21, 2019 13:41

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 21, 2019 13:41 Inactive

anyatibrian approved these changes May 21, 2019

View reviewed changes

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from 213ee2d to c04ee4c Compare May 21, 2019 14:25

patrickf949 temporarily deployed to ah-frontend-prime-pr-15 May 21, 2019 14:25 Inactive

e-ian approved these changes May 21, 2019

View reviewed changes

Genza999 approved these changes May 21, 2019

View reviewed changes

MuhanguziDavid suggested changes May 21, 2019

View reviewed changes

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from c04ee4c to e8b8274 Compare May 21, 2019 15:44

patrickf949 deployed to ah-frontend-prime-pr-15 May 21, 2019 15:45 View deployment

ft(article-crud): enable users create and view articles

f0dd23d

- add routes for article creation and viewing - add necessary pages for article creation and viewing - write tests for all functionality [Finishes #164798256]

patrickf949 force-pushed the ft-users-able-create-articles-164798256 branch from e8b8274 to f0dd23d Compare May 21, 2019 15:47

MuhanguziDavid approved these changes May 21, 2019

View reviewed changes

MuhanguziDavid merged commit 96812aa into develop May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#164798256 Enable users manipulate articles #15

#164798256 Enable users manipulate articles #15

patrickf949 commented May 14, 2019 •

edited

Loading

houndci-bot May 14, 2019

houndci-bot May 14, 2019

houndci-bot May 14, 2019

e-ian May 20, 2019

e-ian May 21, 2019

patrickf949 May 21, 2019

e-ian May 21, 2019

patrickf949 May 21, 2019

e-ian May 21, 2019

anyatibrian left a comment

e-ian left a comment

Genza999 left a comment

MuhanguziDavid left a comment

patrickf949 commented May 21, 2019

MuhanguziDavid left a comment

#164798256 Enable users manipulate articles #15

#164798256 Enable users manipulate articles #15

Conversation

patrickf949 commented May 14, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anyatibrian left a comment

Choose a reason for hiding this comment

e-ian left a comment

Choose a reason for hiding this comment

Genza999 left a comment

Choose a reason for hiding this comment

MuhanguziDavid left a comment

Choose a reason for hiding this comment

patrickf949 commented May 21, 2019

MuhanguziDavid left a comment

Choose a reason for hiding this comment

patrickf949 commented May 14, 2019 •

edited

Loading