Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

164798252 users should be able to reset their passwords #17

Merged
merged 1 commit into from
May 19, 2019

Conversation

anyatibrian
Copy link
Contributor

What does this PR do?

  • Enable users to be able to reset their password in case they have forgotten

Description of tasks to be completed.

  • Add tests for a password reset functionality
  • send a link to the user's email with their password reset token
  • Add pages send an email and resetting password respectively

How should this be manually tested?

Visit the deployed application page on heroku
enter your email that you had registered with in the app,then you will recieve an email with a password reset link, follow this link that will redirect to the password reset page from where you enter and confirm your new password.

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?
#164798252

Screen shots

send password resetlink page
Screenshot 2019-05-16 at 19 45 23

Screenshot 2019-05-16 at 19 51 58

password reset page
Screenshot 2019-05-16 at 19 52 54

@patrickf949 patrickf949 had a problem deploying to ah-frontend-prime-pr-17 May 16, 2019 16:57 Failure
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
src/styles/passwordreset.scss Show resolved Hide resolved
src/styles/passwordreset.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 16, 2019 17:01 Inactive
src/reducers/passwordResetReducer.js Show resolved Hide resolved
src/reducers/passwordChangeReducer.js Show resolved Hide resolved
src/containers/passwordResetEmail.js Show resolved Hide resolved
src/containers/passwordReset.js Show resolved Hide resolved
src/components/passwordResetEmail.js Show resolved Hide resolved
src/components/passwordReset.js Show resolved Hide resolved
src/actions/passwordResetActions.js Show resolved Hide resolved
src/styles/register.scss Show resolved Hide resolved
src/styles/register.scss Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
@anyatibrian anyatibrian changed the title Ft password reset 164798252 164798252 users should be able to reset their passwords May 16, 2019
@e-ian
Copy link
Contributor

e-ian commented May 16, 2019

@anyatibrian I see you have three commits, please squash them into one commit

@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 16, 2019 18:40 Inactive
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 16, 2019 19:22 Inactive
src/utils/validateforms.js Outdated Show resolved Hide resolved
src/utils/regex.js Outdated Show resolved Hide resolved
src/urls.js Outdated Show resolved Hide resolved
src/tests/SocialAuth/SocialAuthReducer.spec.js Outdated Show resolved Hide resolved
src/tests/SocialAuth/SocialAuthContainer.spec.js Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
src/styles/register.scss Outdated Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 17, 2019 14:46 Inactive
@anyatibrian
Copy link
Contributor Author

Nice work @anyatibrian , the functionality works as expected. Please ensure to:

* resolve merge conflicts

* fully test the `passwordReset.js` and `passwordResetEmail.js` files.

am done with the project

Copy link
Contributor

@patrickf949 patrickf949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
Feedback implemented
LGTM

Copy link
Contributor

@MuhanguziDavid MuhanguziDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, however, as we talked about earlier, please add a statement to dismiss previous toasts in your action so as to avoid this

Screen Shot 2019-05-18 at 10 22 39

@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 18, 2019 17:49 Inactive
src/styles/sidedrawer.scss Show resolved Hide resolved
src/styles/sidedrawer.scss Show resolved Hide resolved
src/styles/sidedrawer.scss Show resolved Hide resolved
src/styles/sidedrawer.scss Show resolved Hide resolved
src/styles/sidedrawer.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 18, 2019 17:52 Inactive
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
@anyatibrian
Copy link
Contributor Author

Nice work @anyatibrian , the functionality works as expected. Please ensure to:

* resolve merge conflicts

* fully test the `passwordReset.js` and `passwordResetEmail.js` files.

am done with the project

Nice work, however, as we talked about earlier, please add a statement to dismiss previous toasts in your action so as to avoid this

Screen Shot 2019-05-18 at 10 22 39

done

@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 18, 2019 18:18 Inactive
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/navbar.scss Show resolved Hide resolved
src/styles/app.scss Show resolved Hide resolved
src/components/sideDrawer.js Show resolved Hide resolved
src/components/navbar.js Show resolved Hide resolved
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 18, 2019 18:36 Inactive
@patrickf949 patrickf949 temporarily deployed to ah-frontend-prime-pr-17 May 19, 2019 15:01 Inactive
- add test for the password reset feature
- add views files for the feature
- add validations for the form fields
- add loaders for the feature

 [Finishes 164798252]
Copy link
Contributor

@MuhanguziDavid MuhanguziDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @anyatibrian , LGTM

@MuhanguziDavid MuhanguziDavid merged commit 3a52603 into develop May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants