Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164798178 Add search functionality #42

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

dannylwe
Copy link
Contributor

@dannylwe dannylwe commented May 23, 2019

What does this PR do?

Search articles by title

Description of Task to be completed?

Enables a user to search an article by title

How should this be manually tested?

run git fetch ft-add-search-164798178
run git checkout ft-add-search-164798178
run npm i -S

Any background context you want to provide?

Searches for an article by title

What are the relevant pivotal tracker stories?

#164798178

Copy link

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done but add some tests and fix the merge conflicts

Copy link
Contributor

@ezrogha ezrogha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the PR @dannylwe,
Please provide screenshots for the PR
also kindly rebase and resolve the merge conflicts

@dannylwe dannylwe force-pushed the ft-add-search-164798178 branch 2 times, most recently from 7e85add to 81f85d9 Compare May 24, 2019 10:03
@dannylwe
Copy link
Contributor Author

Good work with the PR @dannylwe,
Please provide screenshots for the PR
also kindly rebase and resolve the merge conflicts

Rebased.

@dannylwe dannylwe force-pushed the ft-add-search-164798178 branch 5 times, most recently from ac5892c to 372e578 Compare May 27, 2019 11:39
- A user should be able to search article by title
[Maintains #166193863]
@hadijahkyampeire hadijahkyampeire merged commit f95a0db into develop Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants