Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164798187 User Should view their reading stats #43

Merged

Conversation

ezrogha
Copy link
Contributor

@ezrogha ezrogha commented May 23, 2019

What does this PR do?

Enable user to view their most recently viewed articles

Description of Task to be completed?

  • Allow a user to view their reading stats

How should this be manually tested?

  • Fetch this branch git fetch origin users-should-see-their-reading-stats-164798187
  • Checkout to the branch git checkout users-should-see-their-reading-stats-164798187
  • Run npm start to view the landing page
  • Login to the app on /Login
  • click Check the Articles Reading Stats

What are the relevant pivotal tracker stories?

#164798187

Screenshots (if appropriate)

Screenshot 2019-05-24 at 11 16 39

Screenshot 2019-05-23 at 22 00 25

@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch 2 times, most recently from af735ee to ff73466 Compare May 23, 2019 19:17
@ezrogha ezrogha added the Finished Label for when a task is done label May 23, 2019
Copy link

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work but it will be more helpful to add a link on the dashboard which a user can click to see the reading stats, it is not user-friendly to expect someone to just type a URL, how will they know it

@hadijahkyampeire
Copy link

Just go into the dashboard component and add a link
<Link to="/reading-stats">Check the Articles Reading Stats</Link>
give it an appropriate color and that's all, however, the test for the dashboard might require to be wrapper in MemoryRouter, ensure you run tests before you push. Incase MemoryRouter make some assertions fail, let me know or change <Link> to <a>, but for internal links ` is preffered.

@ezrogha
Copy link
Contributor Author

ezrogha commented May 24, 2019

Great work but it will be more helpful to add a link on the dashboard which a user can click to see the reading stats, it is not user-friendly to expect someone to just type a URL, how will they know it

Thanks for that keen observation @hadijahkyampeire,
I have implemented your feedback

@ezrogha
Copy link
Contributor Author

ezrogha commented May 24, 2019

Just go into the dashboard component and add a link
<Link to="/reading-stats">Check the Articles Reading Stats</Link>
give it an appropriate color and that's all, however, the test for the dashboard might require to be wrapper in MemoryRouter, ensure you run tests before you push. Incase MemoryRouter make some assertions fail, let me know or change <Link> to `, but for internal links `` is preffered.

I have tried using <Link /> which moved to the page but didn't load any content, I have now opted <a>

@felixkiryowa felixkiryowa had a problem deploying to ah-frontend-sparta-team May 24, 2019 08:29 Failure
@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch from ff73466 to 1b07b4a Compare May 24, 2019 08:31
@felixkiryowa felixkiryowa temporarily deployed to authors-haven-dev May 24, 2019 08:32 Inactive
@felixkiryowa felixkiryowa temporarily deployed to ah-frontend-sparta-team May 24, 2019 08:38 Inactive
@felixkiryowa felixkiryowa temporarily deployed to ah-frontend-sparta-team May 24, 2019 08:49 Inactive
@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch from 1b07b4a to bd359a0 Compare May 24, 2019 08:50
@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch from bd359a0 to d9a0558 Compare May 24, 2019 09:02
@felixkiryowa felixkiryowa temporarily deployed to authors-haven-dev May 24, 2019 09:08 Inactive
@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch from d9a0558 to 907c104 Compare May 24, 2019 09:34
  - User should view their most recent stats

[Maintains #164798187]
@ezrogha ezrogha force-pushed the users-should-see-their-reading-stats-164798187 branch from 907c104 to 6e42b3e Compare May 24, 2019 09:43
Copy link
Contributor

@felixkiryowa felixkiryowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@hadijahkyampeire hadijahkyampeire merged commit 0744677 into develop May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Finished Label for when a task is done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants