Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161541575 Add changes to landing page. #15

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

RonKbS
Copy link
Contributor

@RonKbS RonKbS commented Nov 5, 2018

What does this PR do?

Adds changes to existing landing page and navbar to be displayed on navigating to the main URL.

Description of Task to be completed?

Currently, the landing page requires changes for a better user interface.
This PR adds those changes.

How should this be manually tested?

Pull the changes on a new branch based off of the develop branch and run npm start.
Access http://localhost:3000 and the page will be rendered.

Background context?

N/A

What are the relevant pivotal tracker stories?

161541575

Checklist: I completed these to help reviewers

  • My IDE is configured to follow the ESlint Conventions

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes.

    No? -> write tests and add them to this commit git add . && git commit --amend

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the develop branch.

    No? Unsure? -> execute command git pull --rebase origin develop

@coveralls
Copy link

coveralls commented Nov 5, 2018

Pull Request Test Coverage Report for Build 94

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 73: 0.0%
Covered Lines: 19
Relevant Lines: 19

💛 - Coveralls

@RonKbS RonKbS force-pushed the ft-landing-page-navbar-161541575 branch from e4e9dd0 to 43b7415 Compare November 5, 2018 10:19
(fix)display a landing page and navbar on navigating to main url

[Delivers #161541575]
@RonKbS RonKbS force-pushed the ft-landing-page-navbar-161541575 branch from 43b7415 to a8b38b3 Compare November 5, 2018 12:09
@dondrzzy dondrzzy merged commit 1adefb8 into develop Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants