Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(comments): add comments title #30

Closed
wants to merge 1 commit into from

Conversation

MuhanguziDavid
Copy link
Contributor

What does this PR do?

It adds a header to the comments page showing the article being commented on.

Description of tasks to be completed?

Currently, a user cannot see the article for which he/she is creating or viewing comments.
This PR adds functionality to allow users to see the title of the article for which comments are being created or viewed.

How should this be manually tested?

  • Run npm start
  • Click the comment icon on an article.
    You should be redirected to the comments page with the header showing the article title.

What are the relevant pivotal tracker stories?

#162043517

Any background context you want to add?

N/A

Checklist: I completed these to help reviewers

  • My IDE is configured to follow the ESlint Conventions

  • I have added tests to cover my changes.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the develop branch.

- add the article title as a header for the comments page

[Delivers #162043517]
@coveralls
Copy link

Pull Request Test Coverage Report for Build 446

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.708%

Totals Coverage Status
Change from base Build 428: 0.0%
Covered Lines: 391
Relevant Lines: 395

💛 - Coveralls

Copy link
Contributor

@RonKbS RonKbS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MuhanguziDavid you have not included the chore id in the branch name.

@MuhanguziDavid
Copy link
Contributor Author

Noted @RonKbS , let me change the branch name.

@MuhanguziDavid MuhanguziDavid deleted the ch-add-comment-heading branch November 19, 2018 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants