161348758 User should be able to create an article #19

judeinno · 2018-12-12T10:00:50Z

What does this PR do?

Add feature cor create an article.

Description of Task to be completed?

Add user create article form.
Add drop down for articles to create articles and get all articles
Add container for create article form.
Add component for create article form.
Add actions and reducers for create article.
Add tests

How should this be manually tested?

Go to create article URL: /createArticle
Input the article data:

- Title
- Description
- Tags
- Image
- Body

What are the relevant pivotal tracker stories?

#161348758

Screenshots

Input UI

When Get all articles is active (Dropdown changes fields)

When create article is active(Dropdown changes fields)

codeclimate · 2018-12-12T10:01:06Z

src/components/CreateArticle/index.js

+  </div>
+);
+
+CreateArticle.propTypes = {


Similar blocks of code found in 2 locations. Consider refactoring.

dnuwa · 2018-12-17T09:00:07Z

kindly fix the merge conflicts

tibetegya · 2018-12-17T12:45:45Z

.env

@@ -0,0 +1 @@
+APP_URL=https://ah-backend-thanos-staging.herokuapp.com/api


Add a new line at the end of file

tibetegya · 2018-12-17T12:47:29Z

src/actions/createArticleActions/index.js

+  payload: imageUrl,
+});
+
+const tok = localStorage.getItem('token');


What does tok mean??

Am going to update it

tibetegya · 2018-12-17T13:10:49Z

src/containers/CreateArticlePage/index.js

+  handleSubmit = (event) => {
+    event.preventDefault();
+    const { postArticle, createArticleReducer } = this.props;
+    postArticle({ ...createArticleReducer.articlePostData, tag_list: createArticleReducer.articlePostData.tag_list.split(', ') });


this line is too long

tibetegya · 2018-12-17T13:16:32Z

Resolve merge conflicts

codeclimate

The PR diff size of 14672 lines exceeds the maximum allowed for the inline comments feature.

codeclimate · 2018-12-18T07:14:44Z

src/containers/CreateArticlePage/index.js

+
+const mapStateToProps = ({ createArticleReducer }) => ({ createArticleReducer });
+
+export const mapDispatchToProps = dispatch => ({


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-18T14:23:48Z

src/actions/createArticleActions/index.js

+  const headers = {
+    headers: { Authorization: token },
+  };
+  return axios.post(url, userdata, headers)


Similar blocks of code found in 2 locations. Consider refactoring.

codeclimate · 2018-12-18T14:23:48Z

src/containers/CreateArticlePage/CreateArticlePage.test.js

+    expect(CreateArticlePageComponent).toMatchSnapshot();
+  });
+
+  it('should dispatch a method to get user input', () => {


Similar blocks of code found in 2 locations. Consider refactoring.

brucemakallan

Tried this out on Heroku. All good.

- Add user create article form. - Add container for create article form. - Add component for create article form. - Add actions and reducers for create article. [#161348758]

codeclimate · 2018-12-20T14:47:39Z

Code Climate has analyzed commit dea500e and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate bot reviewed Dec 12, 2018

View reviewed changes

judeinno force-pushed the ft-create-article-161348758 branch 3 times, most recently from b11bdf9 to e621818 Compare December 12, 2018 11:03

judeinno added the still in progress Still being worked on label Dec 13, 2018

judeinno force-pushed the ft-create-article-161348758 branch from e621818 to c2a22d7 Compare December 13, 2018 09:05

judeinno added ready ready for merging and removed still in progress Still being worked on labels Dec 14, 2018

judeinno force-pushed the ft-create-article-161348758 branch 2 times, most recently from 2afda60 to a9c2929 Compare December 17, 2018 10:34

tibetegya reviewed Dec 17, 2018

View reviewed changes

.env Outdated

@@ -0,0 +1 @@

APP_URL=https://ah-backend-thanos-staging.herokuapp.com/api

Copy link

Contributor

tibetegya Dec 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at the end of file

tibetegya reviewed Dec 17, 2018

View reviewed changes

judeinno force-pushed the ft-create-article-161348758 branch from a9c2929 to 99cf14a Compare December 18, 2018 07:09

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

judeinno force-pushed the ft-create-article-161348758 branch from 99cf14a to 97e897b Compare December 18, 2018 07:14

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

judeinno force-pushed the ft-create-article-161348758 branch 6 times, most recently from aedca19 to 5e5d041 Compare December 18, 2018 08:09

judeinno requested review from RachaelNantale, dnuwa, brucemakallan, Sulaiman-Mozes and tibetegya December 18, 2018 11:55

judeinno force-pushed the ft-create-article-161348758 branch from 5e5d041 to fcb64e7 Compare December 18, 2018 14:23

codeclimate bot reviewed Dec 18, 2018

View reviewed changes

judeinno force-pushed the ft-create-article-161348758 branch 6 times, most recently from 932066e to b053275 Compare December 20, 2018 10:00

dnuwa previously approved these changes Dec 20, 2018

View reviewed changes

judeinno dismissed dnuwa’s stale review via a02e624 December 20, 2018 10:11

judeinno force-pushed the ft-create-article-161348758 branch 2 times, most recently from a02e624 to cd38ab7 Compare December 20, 2018 10:16

brucemakallan temporarily deployed to ah-frontend-thanos-devel-pr-19 December 20, 2018 11:20 Inactive

brucemakallan previously approved these changes Dec 20, 2018

View reviewed changes

judeinno dismissed brucemakallan’s stale review via 80cc17c December 20, 2018 12:06

judeinno force-pushed the ft-create-article-161348758 branch from cd38ab7 to 80cc17c Compare December 20, 2018 12:06

judeinno deployed to ah-frontend-thanos-devel-pr-19 December 20, 2018 12:06 View deployment

dnuwa previously approved these changes Dec 20, 2018

View reviewed changes

Sulaiman-Mozes previously approved these changes Dec 20, 2018

View reviewed changes

ft(Create Article): User should be able to create an article

dea500e

- Add user create article form. - Add container for create article form. - Add component for create article form. - Add actions and reducers for create article. [#161348758]

judeinno dismissed stale reviews from Sulaiman-Mozes and dnuwa via dea500e December 20, 2018 14:47

judeinno force-pushed the ft-create-article-161348758 branch from 80cc17c to dea500e Compare December 20, 2018 14:47

dnuwa approved these changes Dec 20, 2018

View reviewed changes

Sulaiman-Mozes approved these changes Dec 20, 2018

View reviewed changes

RachaelNantale approved these changes Dec 20, 2018

View reviewed changes

tibetegya merged commit 588d4d5 into develop Dec 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

161348758 User should be able to create an article #19

161348758 User should be able to create an article #19

judeinno commented Dec 12, 2018 •

edited

Loading

codeclimate bot Dec 12, 2018

dnuwa commented Dec 17, 2018

tibetegya Dec 17, 2018

tibetegya Dec 17, 2018

judeinno Dec 20, 2018

tibetegya Dec 17, 2018

judeinno Dec 20, 2018

tibetegya commented Dec 17, 2018

codeclimate bot left a comment

codeclimate bot Dec 18, 2018

codeclimate bot Dec 18, 2018

codeclimate bot Dec 18, 2018

brucemakallan left a comment

codeclimate bot commented Dec 20, 2018

		@@ -0,0 +1 @@
		APP_URL=https://ah-backend-thanos-staging.herokuapp.com/api


		const mapStateToProps = ({ createArticleReducer }) => ({ createArticleReducer });

		export const mapDispatchToProps = dispatch => ({

161348758 User should be able to create an article #19

161348758 User should be able to create an article #19

Conversation

judeinno commented Dec 12, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshots

codeclimate bot Dec 12, 2018

Choose a reason for hiding this comment

dnuwa commented Dec 17, 2018

tibetegya Dec 17, 2018

Choose a reason for hiding this comment

tibetegya Dec 17, 2018

Choose a reason for hiding this comment

judeinno Dec 20, 2018

Choose a reason for hiding this comment

tibetegya Dec 17, 2018

Choose a reason for hiding this comment

judeinno Dec 20, 2018

Choose a reason for hiding this comment

tibetegya commented Dec 17, 2018

codeclimate bot left a comment

Choose a reason for hiding this comment

codeclimate bot Dec 18, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 18, 2018

Choose a reason for hiding this comment

codeclimate bot Dec 18, 2018

Choose a reason for hiding this comment

brucemakallan left a comment

Choose a reason for hiding this comment

codeclimate bot commented Dec 20, 2018

judeinno commented Dec 12, 2018 •

edited

Loading