#162693956 Fix Heroku Configurations #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnuwa
changed the title
brucemakallan
requested a deployment
to
ah-frontend-thanos-stagi-pr-23
brucemakallan
temporarily deployed
to
ah-frontend-thanos-stagi-pr-23
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
24a83ef
to
ba3ab96
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
ba3ab96
to
f5711ad
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
f5711ad
to
f84cd1b
Compare
package.json
Outdated
| "start": "serve -s dist", | ||
| "build": "webpack --config webpack.prod.js", | ||
| "start:dev": "NODE_ENV=development env-cmd .env webpack-dev-server --open", | ||
| "start:prod": "yarn run build && serve dist", |
There was a problem hiding this comment.
why are you using yarn?
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
f84cd1b
to
ef08c3b
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
ef08c3b
to
3d941ee
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
3d941ee
to
ecbec5f
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
ecbec5f
to
53bb3fa
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
53bb3fa
to
255d735
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
255d735
to
d23dddd
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
d23dddd
to
ee3979b
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
ee3979b
to
59446b8
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
59446b8
to
848e4dc
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
848e4dc
to
015f427
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
015f427
to
c986add
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
c986add
to
5bf1640
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
5bf1640
to
f09f0c5
Compare
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
f09f0c5
to
8660ec8
Compare
- configures app to read heroku environment variables [#162693956]
dnuwa
force-pushed
the
bg-Heroku-Configurations-162693956
branch
from
8660ec8
to
5f2e195
Compare
|
Code Climate has analyzed commit 5f2e195 and detected 0 issues on this pull request. View more on Code Climate. |
dnuwa
requested review from
RachaelNantale,
judeinno,
brucemakallan,
Sulaiman-Mozes and
tibetegya
brucemakallan
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
What are the relevant pivotal tracker stories?
#162693956