Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#59054021 Fix Ratings Bug. #28

Merged
merged 1 commit into from
Aug 16, 2018
Merged

#59054021 Fix Ratings Bug. #28

merged 1 commit into from
Aug 16, 2018

Conversation

dessHub
Copy link

@dessHub dessHub commented Aug 16, 2018

What does this PR do?
Fixes bug on rating response
Also get rid of duplicate rating serializer.

Background information
The message returned had a grammatical error.

How To Manually Test?
fetch origin
git checkout bg-rating-159816402

  • Update database by running migrations.
    python manage.py migrate

  • Run test coverage
    python manage.py test

  • Start the server
    python manage.py runserver

  • Test the endpoints on postman.

Affected Endpoints:
DELETE /api/articles//rate/
Response:

{
    "rate": {
        "response": {
            "message": [
                "Successfull."
            ],
            "avg_ratings": {
                "ratings__avg": 4
            }
        }
    }
}

Screenshot:
screen shot 2018-08-16 at 10 04 08

Relevant Pivotal tracker stories
#159816402 Fix ratings bug.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 94.408% when pulling f2042e7 on bg-rating-159816402 into b8c4073 on develop.

@jacksono jacksono merged commit 47322d6 into develop Aug 16, 2018
@jacksono jacksono deleted the bg-rating-159816402 branch August 16, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants