#166790111: Role based access control functionality #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| type: Sequelize.DATE }, | ||
| updatedAt: { allowNull: false, | ||
| type: Sequelize.DATE } }), | ||
| down: (queryInterface, Sequelize) => queryInterface.dropTable('Permissions') }; |
There was a problem hiding this comment.
'Sequelize' is defined but never used no-unused-vars
kagabof
force-pushed
the
ft-Role-based-access-control-functionality-166790111
branch
4 times, most recently
from
665e8de
to
1b6fba0
Compare
| .then(() => { | ||
| queryInterface.sequelize.query('ALTER TABLE "Permissions" ADD CONSTRAINT "permissions-pks" PRIMARY KEY ("role", "actions")'); | ||
| }), | ||
| down: (queryInterface, Sequelize) => queryInterface.dropTable('Permissions') }; |
There was a problem hiding this comment.
'Sequelize' is defined but never used no-unused-vars
kagabof
force-pushed
the
ft-Role-based-access-control-functionality-166790111
branch
from
1b6fba0
to
4ff05fb
Compare
FlevianK
approved these changes
Jul 29, 2019
kagabof
force-pushed
the
ft-Role-based-access-control-functionality-166790111
branch
from
4ff05fb
to
9f6b4b1
Compare
- Added contoller for the admin to create a role. - Added middleware to check if user is admin. - Added test for role. - Added role in the token. - Changed role data type in the user model.
kagabof
force-pushed
the
ft-Role-based-access-control-functionality-166790111
branch
from
9f6b4b1
to
e6a9e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#166790111
Screenshots
Questions: