#166790110: Super admin should be able to create users #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
2 times, most recently
from
ce51e80
to
5d440fc
Compare
FlevianK
suggested changes
Jul 30, 2019
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
from
5d440fc
to
1686f27
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
from
1686f27
to
dad9ce7
Compare
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
3 times, most recently
from
0ba1ec9
to
f1f0ade
Compare
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
from
f1f0ade
to
dacd2f9
Compare
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
from
dacd2f9
to
98cca19
Compare
- Added test for the admin fationality. - Added routers for the admin factionality, - Added swagger documentation for admin fanctionality.
kagabof
force-pushed
the
ft-super-admin-create-users-166790110
branch
from
98cca19
to
256b490
Compare
FlevianK
reviewed
Jul 31, 2019
|
|
||
| router.delete('/api/users/:id', verifyToken, checkAction('User'), UserController.deleteUser); |
There was a problem hiding this comment.
Why are you having this action checkAction('User') here and not at the controller level?
There was a problem hiding this comment.
checkAction is a middleware function that checks if a user trying to access the router has the priority of deleting in a user table.
FlevianK
reviewed
Jul 31, 2019
| @@ -31,20 +32,32 @@ class UserProfile { | |||
| * @return {object} returns an object containing the updated user profile | |||
| */ | |||
| static async updateProfile(req, res) { | |||
There was a problem hiding this comment.
This should be refactored better during code maintainability session
FlevianK
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
By using postman:
By using swagger documentation.
-By running test: npm run test.
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#166790110
Screenshots
Questions: