Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#166790096 refactoring likes and dislikes #47

Closed
wants to merge 1 commit into from

Conversation

pngabo
Copy link
Contributor

@pngabo pngabo commented Jul 31, 2019

What does this PR do?

  • Refactoring article likes and dislikes

Description of Task to be completed?

  • reduce duplication and a number of lines that compose a function

How should this be manually tested?

N/A

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

N/A

Screenshots (if appropriate)

Questions:

const { res, article, userReacted, articleId, id,
disliked, liked, dislikedArticle, LikeAndDislike } = args;
const { countArticleDisikesLikes, ChangeLikeStatus,
updateArticleDisliskes } = LikesDislikesHelpers;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected a line break before this closing brace object-curly-newline

export default async (args) => {
const { res, article, userReacted, articleId, id,
disliked, liked, dislikedArticle, LikeAndDislike } = args;
const { countArticleDisikesLikes, ChangeLikeStatus,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected a line break after this opening brace object-curly-newline


export default async (args) => {
const { res, article, userReacted, articleId, id,
disliked, liked, dislikedArticle, LikeAndDislike } = args;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected a line break before this closing brace object-curly-newline

import LikesDislikesHelpers from '../controllers/helpers/likeAndDislikes';

export default async (args) => {
const { res, article, userReacted, articleId, id,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected a line break after this opening brace object-curly-newline

@pngabo pngabo force-pushed the ch-refactor-likes-dislike-166790096 branch from f7e78c0 to f9ef8c5 Compare July 31, 2019 18:44
@pngabo pngabo force-pushed the ch-refactor-likes-dislike-166790096 branch from f9ef8c5 to 88f87ef Compare July 31, 2019 18:52
@pngabo pngabo closed this Jul 31, 2019
@pngabo pngabo deleted the ch-refactor-likes-dislike-166790096 branch July 31, 2019 19:00
@pngabo pngabo restored the ch-refactor-likes-dislike-166790096 branch July 31, 2019 19:09
@pngabo pngabo deleted the ch-refactor-likes-dislike-166790096 branch July 31, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant