Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bg: Fix social login bugs #52

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from
Open

bg: Fix social login bugs #52

wants to merge 34 commits into from

Conversation

kagabof
Copy link
Contributor

@kagabof kagabof commented Aug 22, 2019

What does this PR do?

  • fixing social login.

Description of Task to be completed?

  • changed the redirect URL google.

How should this be manually tested?

  • by running the google URL.

@kagabof kagabof temporarily deployed to ah-jawans-backend August 22, 2019 15:18 Inactive
@kagabof kagabof temporarily deployed to ah-jawans-backend August 22, 2019 15:44 Inactive
@@ -17,6 +17,7 @@ const createUser = async (newUser, res, displayName) => {
};

const displayOutput = async (req, res, displayName) => {
console.log(req.user);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected console statement no-console

@kagabof kagabof temporarily deployed to ah-jawans-backend August 22, 2019 19:47 Inactive
- edited the route for gogole route.
@kagabof kagabof temporarily deployed to ah-jawans-backend August 22, 2019 21:38 Inactive
@kagabof kagabof temporarily deployed to ah-jawans-backend August 22, 2019 21:51 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend August 24, 2019 11:23 Inactive
storage,
limits: { fileSize: MAX_IMAGE_SIZE }
});
export default multerUploads;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline required at end of file but not found eol-last

const multerUploads = multer({
storage,
limits: { fileSize: MAX_IMAGE_SIZE }
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

export default multerUploads;
allowedFormat: ['jpg', 'png', 'jpeg']
});
const multerUploads = multer({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

limits: { fileSize: MAX_IMAGE_SIZE } });
export default multerUploads;
allowedFormat: ['jpg', 'png', 'jpeg']
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

@@ -10,9 +10,13 @@ const MAX_IMAGE_SIZE = 1 * 1024 * 1024; // Maximum allowed image size: 1MB

const cdnConnect = cloudinaryConfig();

const storage = cloudinaryStorage({ cloudinary,
const storage = cloudinaryStorage({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

const { displayName } = req.user;
await displayOutput(req, res, displayName);
},
const userInfo = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

email: req.user.emails[0].value,
image: req.user.photos[0].value,
provider: req.user.provider, });
provider: req.user.provider,
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

}
};

const displayOutput = async (req, res, displayName) => {
const newUser = await User.create({ firstName: req.user.name.givenName,
const newUser = await User.create({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

return res.status(201).json({
message: `Welcome to Authors Haven ${displayName} `,
data: { token, firstName, lastName, username, email },
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

@@ -11,41 +11,49 @@ const createUser = async (newUser, res, displayName) => {
}
} = newUser;
const token = await tokenGeneration.generateToken(newUser.dataValues);
return res.status(201).json({ message: `Welcome to Authors Haven ${displayName} `,
data: { token, firstName, lastName, username, email }, });
return res.status(201).json({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend August 25, 2019 11:31 Inactive
- edited the route for gogole route.
- Added validations back to user profile amend
image.version
}/${image.public_id}.${image.format}`
}
})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

circle: `${IMAGE_BASE_URL}/w_120,c_fill,ar_1:1,g_auto,r_max,bo_5px_solid_red,b_rgb:262c35/v${
image.version
}/${image.public_id}.${image.format}`
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

}/${image.public_id}.${image.format}`,
circle: `${IMAGE_BASE_URL}/w_120,c_fill,ar_1:1,g_auto,r_max,bo_5px_solid_red,b_rgb:262c35/v${
image.version
}/${image.public_id}.${image.format}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 10 spaces but found 12 indent

}`,
square: `${IMAGE_BASE_URL}/w_320,ar_1:1,c_fill,g_auto,e_art:hokusai/v${
image.version
}/${image.public_id}.${image.format}`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 10 spaces but found 12 indent

original: `v${image.version}/${image.public_id}.${image.format}`,
thumbnail: `${IMAGE_BASE_URL}/w_600/v${image.version}/${image.public_id}.${
image.format
}`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected indentation of 10 spaces but found 12 indent

}))
&& res.status(201).json({
status: 201,
message: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

image: `${image.version}/${image.public_id}.${image.format}`,
userId: req.user.id
}))
&& res.status(201).json({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

? (await Gallery.save({
image: `${image.version}/${image.public_id}.${image.format}`,
userId: req.user.id
}))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break before this closing brace object-curly-newline

circle: `${IMAGE_BASE_URL}/w_120,c_fill,ar_1:1,g_auto,r_max,bo_5px_solid_red,b_rgb:262c35/v${
image.version
}/${image.public_id}.${image.format}` } })
? (await Gallery.save({
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected line break after this opening brace object-curly-newline

@@ -14,21 +14,28 @@ export default class UploadController {
* @returns {object} Object representing the response returned
*/
static async save(req, res) {
console.log('idhar aya hai kya');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected console statement no-console

@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend August 25, 2019 12:39 Inactive
@Joe-Joseph Joe-Joseph temporarily deployed to ah-jawans-backend August 27, 2019 15:28 Inactive
@mnzube mnzube force-pushed the bg-fix-bag branch 2 times, most recently from 5f57bab to ee09afa Compare August 28, 2019 07:45
@mnzube mnzube temporarily deployed to ah-jawans-backend August 28, 2019 07:53 Inactive
- edited the route for gogole route.
- Added validations back to user profile amend
@mnzube mnzube temporarily deployed to ah-jawans-backend August 28, 2019 07:57 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend August 28, 2019 10:10 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend August 28, 2019 10:28 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 16, 2019 16:22 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 16, 2019 16:24 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 16, 2019 16:30 Inactive
@mnzube mnzube force-pushed the bg-fix-bag branch 2 times, most recently from 9483c03 to 1f5cf67 Compare September 16, 2019 16:37
@mnzube mnzube temporarily deployed to ah-jawans-backend September 16, 2019 16:38 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 16, 2019 16:48 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend September 17, 2019 13:33 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 18, 2019 10:11 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 18, 2019 10:56 Inactive
@mnzube mnzube temporarily deployed to ah-jawans-backend September 18, 2019 13:54 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend September 19, 2019 08:13 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend September 19, 2019 09:23 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend September 19, 2019 15:06 Inactive
@shaluchandwani shaluchandwani temporarily deployed to ah-jawans-backend September 19, 2019 15:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants