-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#161967010 Verify User Registration through Email #16
Conversation
e40f675
to
9e20483
Compare
9e20483
to
272b078
Compare
272b078
to
3925ee8
Compare
e42cfc4
to
236e048
Compare
Nice work. A few missing instructions on the readme, to checkout to your branch, database configuration and the environment variables need to be added as well. |
d66fe28
to
b3f4144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces changes that require re-writing of most of the other PR's. I would recommend that it be merged last.
72950cf
to
5f09e8b
Compare
Kindly check on the tests |
5f09e8b
to
32d7b16
Compare
32d7b16
to
6fef8c8
Compare
6fef8c8
to
b2f6b06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this. Works great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
b2f6b06
to
712b220
Compare
712b220
to
ac1a319
Compare
ac1a319
to
4e42bdc
Compare
d194c6d
to
e54e2fe
Compare
e1e5774
to
21a24a9
Compare
b37d0e8
to
3eb82ac
Compare
3eb82ac
to
6019c84
Compare
- set third party configs in the settings file - add code in registration endpoint to send mail to the registered user - create new activation endpoint that will activate the user - write tests for the new and modified endpoints [Delivers #161967010]
6019c84
to
0b9efe2
Compare
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
git clone
this repo to your local machine.pip install -r requirements.txt
python manage.py makemigrations && python manage.py migrate
.python manage.py runserver
and navigate to the link below.http://localhost:8000/api/users/register
dictionary with user.
to the page where your activation will occur. If activation is successful, the message,
Activation is successful will be returned else, Activation link is invalid.
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#161967010
Screenshots (if appropriate)
![screenshot 2018-12-06 at 14 03 15](https://user-images.githubusercontent.com/28791783/49580372-d412a080-f95f-11e8-8080-8ac21751d6a1.png)
----------------------------------------------***---------------------------------------------------Questions:
Checklist: