166840939 like specific comment #38

olorunwalawrence · 2019-07-22T04:38:02Z

What does this PR do?

Like a specific comment

Description of the task to be completed

create like functionality
create like route and middleware

How to manually test this PR

clone the repo
on your terminal, run 166840939-like-specific-comment
create a user model and migration
on your terminal, run npm install to install dependencies
on your terminal, run npm run start:dev to start the application.

What is the story identity?

#166840919

hound · 2019-07-22T04:38:08Z

src/routes/v1/comment.route.js

@@ -0,0 +1,17 @@
+import express from 'express';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-22T04:38:09Z

src/middleware/like.middleware.js

@@ -0,0 +1,44 @@
+import checkProp from '../helpers/utils';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-22T04:38:09Z

src/helpers/commentHelpers.js

@@ -0,0 +1,27 @@
+import responseGenerator from './responseGenerator';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-22T04:38:09Z

src/database/models/commentlikes.js

+  return CommentLikes;
+};
+
+export default commentLikes;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-22T04:38:09Z

src/database/models/comment.js

+  return Comments;
+};
+
+export default comments;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-22T04:38:09Z

src/database/migrations/20190720080427-create-commentlikes.js

@@ -0,0 +1,46 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-07-22T04:38:09Z

src/database/migrations/20190716074627-create-comment.js

@@ -0,0 +1,46 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-07-22T04:38:10Z

src/controllers/like.controller.js

@@ -0,0 +1,25 @@
+import models from '../database/models/index';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

timi-codes

Good Job @olorunwalawrence, Please document your endpoints and use the Joi validation middleware instead of the check props as we discussed

timi-codes · 2019-07-24T10:29:48Z

src/helpers/utils.js

+   * @param  {String} type The list of properties to be searched for
+   * @returns {object} An object that contains a valid (bool) and invalidMessages (array) property
+   */
+  checkProps(obj, params, type) {


Please use Joi validation middleware for this.

hound · 2019-07-29T08:33:06Z

src/database/migrations/20190729080444-create-commentlikes.js

@@ -0,0 +1,46 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-07-29T08:33:06Z

src/database/migrations/20190728182943-create-comment.js

@@ -0,0 +1,46 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-07-29T08:33:07Z

src/controllers/comment.controller.js

@@ -0,0 +1,73 @@
+/* eslint-disable require-jsdoc */
+import models from '../database/models';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-29T08:33:09Z

src/database/models/commentlikes.js

+  return CommentLike;
+};
+
+export default commentLike;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

Onyimatics

Good job @olorunwalawrence. Please kindly resolve the conflicts on this PR and also squash your commits. Thank you

tolumide-ng

Good job so far @olorunwalawrence , Please check my comments and make the necessary changes. I would also love to know your opinion on the possibility of the author of a comment liking their own comment

tolumide-ng · 2019-08-06T12:27:03Z

src/helpers/commentHelpers.js

+        }
+
+        // This block creates the toggle effect of liking and unliking
+        return model.update({ liked: !liked }, { where: likeData }).then(() => {


Hello, this should be implemented as remove since we would not be having a dislike feature on the project.
The first request to this api adds the like for such comment while the second removes the likes

tolumide-ng · 2019-08-06T12:30:50Z

src/database/migrations/20190728182943-create-comment.js

@@ -0,0 +1,46 @@
+module.exports = {
+  up: (queryInterface, Sequelize) =>


There seems to be two create-comment migration files here. could you remove one?

tolumide-ng · 2019-08-06T12:33:13Z

src/database/migrations/20190729080444-create-commentlikes.js

+module.exports = {
+  up: (queryInterface, Sequelize) =>
+    queryInterface.createTable(
+      'CommentLike',


This is a migration file, so the tableName should be plural. Sequelize should normally do this by default. Please make the changes here

tolumide-ng · 2019-08-06T12:35:59Z

src/database/migrations/20190729080444-create-commentlikes.js

+            as: 'userId'
+          }
+        },
+        liked: {


A user should only be able to like a comment and NOT unlike. Hence if the user has liked the comment before, they should be able to remove such like on the comment. I think there is no need or this column in that case.

This table should only reflect list of people that have liked a specific article and when someone removes there like? then the row should be removed from this table

tolumide-ng · 2019-08-06T12:38:32Z

src/database/models/comment.js

@@ -0,0 +1,49 @@
+const comments = (sequelize, DataTypes) => {
+  const Comments = sequelize.define(
+    'Comments',


Model should have singular name to maintain consistency within the project, please check here https://github.com/andela/ah-kifaru-backend/blob/develop/src/database/models/follower.js

Hence, when creating a comment table use: =>cmd to create table comment<=

This has been solved on the comment branch

tolumide-ng · 2019-08-06T12:47:23Z

src/test/article.spec.js

+    );
+  });
+
+  it('sshould unlike a comment for an article', async () => {


tolumide-ng · 2019-08-06T12:49:11Z

src/test/article.spec.js

+    expect(res.body.data).to.be.equal('Comment liked');
+  });
+
+  it('should throw error if article id is invalid', async () => {


This test should not depend on the previous, please create a separate user or this test

kindly check below to see the user creating the like

tolumide-ng · 2019-08-06T12:50:35Z

src/test/article.spec.js

+    );
+  });
+
+  it('sshould unlike a comment for an article', async () => {


The current project does not support features like unlike, users should only be able to remove there previous likes. Please amend this.

but this branch support feature that makes an authenticated user to like or unlike a specific comment. the PT board story says "Users should be able to like a specific comment".
if I have liked a specific comment and then later I am not interested in such comment anymore I should unlike it.

tolumide-ng · 2019-08-06T12:55:30Z

src/controllers/like.controller.js

+  const userId = req.currentUser.id;
+
+  const likeData = { commentId, userId };
+  return liker(CommentLike, res, likeData, 'Comment');


Good job @olorunwalawrence , is there a reason why you abstracted the liker method?

tolumide-ng · 2019-08-06T12:57:42Z

src/controllers/like.controller.js

+const { liker } = commentHelpers;
+
+const likeController = async (req, res) => {
+  const { commentId: id } = req.params;


There seems to be no check for the aspiring liker being the author of the comment. This means the author of a comment can like their own comment.

I think this is cool, there is no need to check for any aspiring liker because we are not stating any statistics base on the number of users that like specific comment, any user can like any comment

hound · 2019-08-08T07:29:17Z

src/database/migrations/20190729080444-create-commentlike.js

@@ -0,0 +1,46 @@
+module.exports = {


'module' is not defined no-undef

hound · 2019-08-08T08:18:54Z

src/database/models/Report.js

@@ -0,0 +1,44 @@
+export default (sequelize, DataTypes) => {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-08-08T08:18:54Z

src/database/migrations/20190715211346-create-report.js

@@ -0,0 +1,59 @@
+module.exports = {


'module' is not defined no-undef

- create like functionality - create middleware for like - create route for like [Delivers #166840939]

hound bot reviewed Jul 22, 2019

View reviewed changes

olorunwalawrence assigned timi-codes, tohbay and tolumide-ng Jul 22, 2019

timi-codes suggested changes Jul 24, 2019

View reviewed changes

olorunwalawrence force-pushed the 166840939-like-specific-comment branch from 02ebecb to b6aaa09 Compare July 29, 2019 08:32

hound bot reviewed Jul 29, 2019

View reviewed changes

olorunwalawrence force-pushed the 166840939-like-specific-comment branch 3 times, most recently from 8d66e74 to 4e6a12c Compare July 31, 2019 14:03

olorunwalawrence assigned codexempire Aug 1, 2019

Onyimatics suggested changes Aug 1, 2019

View reviewed changes

olorunwalawrence force-pushed the 166840939-like-specific-comment branch from 8144530 to 9d46659 Compare August 2, 2019 09:20

tolumide-ng suggested changes Aug 6, 2019

View reviewed changes

hound bot reviewed Aug 8, 2019

View reviewed changes

src/database/migrations/20190729080444-create-commentlike.js Outdated

@@ -0,0 +1,46 @@

module.exports = {

Copy link

hound bot Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'module' is not defined no-undef

olorunwalawrence force-pushed the 166840939-like-specific-comment branch 2 times, most recently from 0a7c5d4 to 15d3797 Compare August 8, 2019 08:18

hound bot reviewed Aug 8, 2019

View reviewed changes

ft(like): create like comment

b6ff3d9

- create like functionality - create middleware for like - create route for like [Delivers #166840939]

olorunwalawrence force-pushed the 166840939-like-specific-comment branch from 15d3797 to b6ff3d9 Compare August 9, 2019 09:21

olorunwalawrence merged commit 04082cc into develop Aug 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

166840939 like specific comment #38

166840939 like specific comment #38

olorunwalawrence commented Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

hound bot Jul 22, 2019

timi-codes left a comment

timi-codes Jul 24, 2019

hound bot Jul 29, 2019

hound bot Jul 29, 2019

hound bot Jul 29, 2019

hound bot Jul 29, 2019

Onyimatics left a comment

tolumide-ng left a comment

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

olorunwalawrence Aug 6, 2019

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

olorunwalawrence Aug 6, 2019

tolumide-ng Aug 6, 2019

olorunwalawrence Aug 6, 2019

tolumide-ng Aug 6, 2019

tolumide-ng Aug 6, 2019

olorunwalawrence Aug 6, 2019

hound bot Aug 8, 2019

hound bot Aug 8, 2019

hound bot Aug 8, 2019

		@@ -0,0 +1,27 @@
		import responseGenerator from './responseGenerator';

		@@ -0,0 +1,25 @@
		import models from '../database/models/index';

		@@ -0,0 +1,73 @@
		/* eslint-disable require-jsdoc */
		import models from '../database/models';

		@@ -0,0 +1,46 @@
		module.exports = {
		up: (queryInterface, Sequelize) =>

166840939 like specific comment #38

166840939 like specific comment #38

Conversation

olorunwalawrence commented Jul 22, 2019

What does this PR do?

Description of the task to be completed

How to manually test this PR

What is the story identity?

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

hound bot Jul 22, 2019

Choose a reason for hiding this comment

timi-codes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Jul 29, 2019

Choose a reason for hiding this comment

hound bot Jul 29, 2019

Choose a reason for hiding this comment

hound bot Jul 29, 2019

Choose a reason for hiding this comment

hound bot Jul 29, 2019

Choose a reason for hiding this comment

Onyimatics left a comment

Choose a reason for hiding this comment

tolumide-ng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 8, 2019

Choose a reason for hiding this comment

hound bot Aug 8, 2019

Choose a reason for hiding this comment

hound bot Aug 8, 2019

Choose a reason for hiding this comment