#164243636 Implement pep8 standards on codebase #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMonstro
requested review from
BrianSerem,
cob04,
abulojoshua1,
Etomovich,
MandelaK and
RachelleMaina
RachelleMaina
approved these changes
Mar 1, 2019
ElMonstro
force-pushed
the
ch-implement-pep8-164243636
branch
from
da05689
to
43b2368
Compare
cob04
approved these changes
Mar 1, 2019
abulojoshua1
reviewed
Mar 1, 2019
ElMonstro
force-pushed
the
ch-implement-pep8-164243636
branch
from
43b2368
to
8cda689
Compare
abulojoshua1
reviewed
Mar 1, 2019
install flake8 and create .flake8 config file - add flake8 script to .travis.yml - fix pep8 errors on codebase [Finishes #164243636]
ElMonstro
force-pushed
the
ch-implement-pep8-164243636
branch
from
8cda689
to
5ce5c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds testing of code for PEP8 style guide compliance
Description of Task to be completed?
How should this be manually tested?
git clone -b origin/ch-implement-pep8-164243636 https://github.com/andela/ah-legion-backend.gitpip install -r requirements.txtfrom the root folder.find ./authors/ -name \*.py -exec flake8 -v {} +Any background context you want to provide?
PEP8 styled code is highly readable and easier to maintain
What are the relevant pivotal tracker stories?
#164243636