#164046256 Users Should Follow Each Other #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSerem
requested review from
ElMonstro,
abulojoshua1,
Etomovich,
RachelleMaina,
MandelaK and
cob04
and removed request for
ElMonstro
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
f5cd7b9
to
dd22308
Compare
Etomovich
approved these changes
Mar 14, 2019
RachelleMaina
approved these changes
Mar 14, 2019
MandelaK
approved these changes
Mar 14, 2019
abulojoshua1
suggested changes
Mar 14, 2019
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
dd22308
to
e4278d6
Compare
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
e4278d6
to
d697b31
Compare
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
d697b31
to
515269d
Compare
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
515269d
to
ee2e9ac
Compare
abulojoshua1
approved these changes
Mar 14, 2019
abulojoshua1
suggested changes
Mar 14, 2019
-write tests on following/follower feature -create manytomany field on follower/followee -create views and serializers on this feature -verify if tests running [Finishes #164046256]
BrianSerem
force-pushed
the
ft-users-follow-eachother-164046256
branch
from
ee2e9ac
to
7ce5218
Compare
Was waiting for @ElMonstro 's PR to be merged, it fixed the failing build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull request implements users' abiity to follow each other, an existing user may be followed by another user.
These endpoints will now be working:
GET
/api/profiles/<username>/follow/- Follow a userDELETE
/api/profiles/<username>/follow/- Unfollow a userGET
/api/profiles/<username>/following/- Get a users statistics: followers/followees**Type of change**
How has this been tested
How to test this manually
Using Postman, navigate to https://ah-legion-staging-pr-22.herokuapp.com, use instructions below to test the various endpoints.
: Follow a user
https://ah-legion-staging-pr-22.herokuapp.com/api/profiles/
Unfollow a user:
https://ah-legion-staging-pr-22.herokuapp.com/api/profiles/username/
Get user statistics: Number of followers and followees:
https://ah-legion-staging-pr-22.herokuapp.com/api/profiles/username/followings/
**Checklist:**
Related Stories
#164046256