#164046210: users can log in #13

MandelaK · 2019-04-08T18:54:54Z

What does this PR do?

Add login functionality to the application. When a user fills in the login form, they should get an appropriate response. Error messages are displayed in red and form validation is done when the form is submitted.

Description of task

Users should be able to log in so they can be identified and have a custom experience. When a user logs in, we store the token and dispatch an action to the redux store. A helper function is implemented to ensure that only valid tokens can be decoded.

The following are saved to localStorage when a user logs in:
- profileImage - Link to the user's profile image
- token - The user's token
- email - The user's email
- username - The username of the user

How has this been tested?

End-to-end testing
Unit tests

How can this be manually tested?

Clone this repo and checkout to the branch ft-users-login-#164046210
run npm install and create a .env file in your environment variables. Add the variable REACT_APP_BASE_URL to the env file and have it's value point to https://ah-legion-staging.herokuapp.com/api/ or your custom backend. Also add a REACT_APP_SECRET_KEY which should be the same as that on heroku.
Go to the login page and try logging in a user

Other information

I have implemented a function in the utils that checks whether a user is logged in by attempting to authenticate the token stored in the localStorage
Make sure you have run npm install and properly configure environment variables. Also restart your server and run source .env.
You can use axiosConfig to make API calls

PT

164046210

src/store/actions/authActions/LoginAction.jsx

src/store/actions/authActions/LoginAction.js

src/containers/LoginForm.jsx

src/utils/validation.js

src/store/actions/authActions/LoginAction.js

abulojoshua1 · 2019-04-11T15:46:27Z

@MandelaK, kindly rebase so as to add coveralls to your PR.

src/utils/testHelpers.js

src/containers/LoginForm.jsx

src/components/Header.jsx

src/containers/LoginForm.jsx

src/index.jsx

RachelleMaina

This looks good.

cob04

Looks OK

ElMonstro

Approved

src/store/reducers/index.js

src/containers/LoginForm.jsx

src/tests/store/Actions/authActions/loginAction.test.js

src/components/Header.jsx

src/containers/LoginForm.jsx

ElMonstro · 2019-04-16T18:59:07Z

Please fix the hound format @MandelaK

src/containers/LoginForm.jsx

src/store/actions/authActions/LoginAction.js

src/containers/LoginForm.jsx

src/css/App.css

src/containers/LoginForm.jsx

abulojoshua1 · 2019-04-17T12:32:24Z

@MandelaK], kindly fix the merge conflicts.

src/containers/LoginForm.jsx

- create login form - users can log in - errors are displayed above the specific input fields and input fields have a red border if they are not validated - set up validation of input fields - configure axios - test loginReducer - test login validator function - tokens are stored in localStorage on successful login - add function for validating authentication tokens - add function for checking whether a user is logged in with valid jwt token - users are redirected on successful login to the homepage - logged in users cannot see the login form - test login form - add a spinner when a user is logging in - store profile image, username and token when a user logs in [starts #164046210] [finishes #164046210]

abulojoshua1

LGTM

MandelaK added the Work In Progress The task/feature you were working on is not yet complete. Show the team where you are so far. label Apr 8, 2019

houndci-bot reviewed Apr 8, 2019

View reviewed changes

src/store/actions/authActions/LoginAction.jsx Outdated Show resolved Hide resolved

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

src/containers/LoginForm.jsx Outdated Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch from d4e9816 to 925ea31 Compare April 9, 2019 18:25

houndci-bot reviewed Apr 9, 2019

View reviewed changes

src/utils/validation.js Show resolved Hide resolved

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch 2 times, most recently from 8936f1d to 881938e Compare April 12, 2019 03:00

houndci-bot reviewed Apr 12, 2019

View reviewed changes

src/utils/testHelpers.js Outdated Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch 5 times, most recently from 21513f9 to ade0b36 Compare April 12, 2019 11:02

MandelaK marked this pull request as ready for review April 14, 2019 11:57

MandelaK force-pushed the ft-users-login-#164046210 branch from ade0b36 to 519e3e9 Compare April 15, 2019 08:46

houndci-bot reviewed Apr 15, 2019

View reviewed changes

src/containers/LoginForm.jsx Outdated Show resolved Hide resolved

src/components/Header.jsx Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch from 519e3e9 to bffa2d6 Compare April 15, 2019 09:32

MandelaK added Completed You are done with what you were working on. Use to ask the team for reviews before a potential merge and removed Work In Progress The task/feature you were working on is not yet complete. Show the team where you are so far. labels Apr 15, 2019

MandelaK requested review from Etomovich, RachelleMaina, abulojoshua1, BrianSerem, cob04 and ElMonstro April 15, 2019 09:33

MandelaK force-pushed the ft-users-login-#164046210 branch from bffa2d6 to 2580f7d Compare April 15, 2019 15:59

MandelaK changed the title ~~feat(login) users can log in~~ #164046210: users can log in Apr 15, 2019

houndci-bot reviewed Apr 15, 2019

View reviewed changes

MandelaK force-pushed the ft-users-login-#164046210 branch from 2580f7d to e27770d Compare April 15, 2019 16:20

houndci-bot reviewed Apr 15, 2019

View reviewed changes

cob04 reviewed Apr 16, 2019

View reviewed changes

src/index.jsx Show resolved Hide resolved

Etomovich approved these changes Apr 16, 2019

View reviewed changes

MandelaK force-pushed the ft-users-login-#164046210 branch from 0bf8e35 to 8261bc0 Compare April 16, 2019 10:53

RachelleMaina approved these changes Apr 16, 2019

View reviewed changes

BrianSerem approved these changes Apr 16, 2019

View reviewed changes

cob04 self-requested a review April 16, 2019 11:48

cob04 approved these changes Apr 16, 2019

View reviewed changes

MandelaK force-pushed the ft-users-login-#164046210 branch from 8261bc0 to a548d3d Compare April 16, 2019 13:03

ElMonstro approved these changes Apr 16, 2019

View reviewed changes

MandelaK force-pushed the ft-users-login-#164046210 branch from a548d3d to 1704693 Compare April 16, 2019 19:46

houndci-bot reviewed Apr 16, 2019

View reviewed changes

src/containers/LoginForm.jsx Show resolved Hide resolved

src/containers/LoginForm.jsx Show resolved Hide resolved

src/containers/LoginForm.jsx Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch 3 times, most recently from 4bbe1b0 to 86d68e0 Compare April 17, 2019 06:54

houndci-bot reviewed Apr 17, 2019

View reviewed changes

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

src/store/actions/authActions/LoginAction.js Outdated Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch 2 times, most recently from c0958ae to f16e68e Compare April 17, 2019 10:34

houndci-bot reviewed Apr 17, 2019

View reviewed changes

src/containers/LoginForm.jsx Show resolved Hide resolved

src/containers/LoginForm.jsx Show resolved Hide resolved

abulojoshua1 suggested changes Apr 17, 2019

View reviewed changes

MandelaK force-pushed the ft-users-login-#164046210 branch 2 times, most recently from 1be081e to 1c1ff78 Compare April 17, 2019 12:30

MandelaK force-pushed the ft-users-login-#164046210 branch from 1c1ff78 to 29347d9 Compare April 17, 2019 13:08

ElMonstro deployed to ah-legion-frontend-stagi-pr-13 April 17, 2019 13:09 View deployment

houndci-bot reviewed Apr 17, 2019

View reviewed changes

src/containers/LoginForm.jsx Outdated Show resolved Hide resolved

MandelaK force-pushed the ft-users-login-#164046210 branch from 29347d9 to a3c9b00 Compare April 17, 2019 13:09

abulojoshua1 approved these changes Apr 17, 2019

View reviewed changes

abulojoshua1 merged commit 188fb19 into develop Apr 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#164046210: users can log in #13

#164046210: users can log in #13

MandelaK commented Apr 8, 2019 •

edited

Loading

abulojoshua1 commented Apr 11, 2019

RachelleMaina left a comment

cob04 left a comment

ElMonstro left a comment

ElMonstro commented Apr 16, 2019

abulojoshua1 commented Apr 17, 2019

abulojoshua1 left a comment

#164046210: users can log in #13

#164046210: users can log in #13

Conversation

MandelaK commented Apr 8, 2019 • edited Loading

What does this PR do?

Description of task

How has this been tested?

How can this be manually tested?

Other information

PT

abulojoshua1 commented Apr 11, 2019

RachelleMaina left a comment

Choose a reason for hiding this comment

cob04 left a comment

Choose a reason for hiding this comment

ElMonstro left a comment

Choose a reason for hiding this comment

ElMonstro commented Apr 16, 2019

abulojoshua1 commented Apr 17, 2019

abulojoshua1 left a comment

Choose a reason for hiding this comment

MandelaK commented Apr 8, 2019 •

edited

Loading