Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165530654 Verify users' emails #29

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

ElMonstro
Copy link
Contributor

What does this PR do?

Enable users to verify their emails when they click the verify link in their emails

Description

  • Users get a success or error message depending on the validity of the token
  • This also fixes a bug in the reset password feature

How has this been tested?

  • Unit tests
  • Integration tests

How to manually test this:

  • Clone the repository https://github.com/andela/ah-legion-frontend
  • Checkout the branch ft-verify-user-165530654
  • Run npm install to instal the required necessary node modules
  • Click a verification link

PT

#165530654

@abulojoshua1
Copy link
Contributor

@ElMonstro, use labels always.

@ElMonstro ElMonstro force-pushed the ft-verify-user-165530654 branch 3 times, most recently from ea08b49 to 9f21a97 Compare April 24, 2019 08:44
@abulojoshua1
Copy link
Contributor

abulojoshua1 commented Apr 24, 2019

Also, use a more descriptive message commit next time.

- fix reset password bug
- write tests

[finishes #165530654]
Copy link
Contributor

@abulojoshua1 abulojoshua1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abulojoshua1 abulojoshua1 merged commit 34db1f4 into develop Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants