#166841012 Integrate social Login #17
Conversation
install passport install passport-facebook install passport-google-oauth20 install passport-twitter initialise passport strategies [#166841012]
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
src/controllers/socialController.js
Outdated
| }); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Newline required at end of file but not found eol-last
src/controllers/socialController.js
Outdated
| static async socialUser(req, res) { | ||
| try { | ||
| const userData = req.authInfo; | ||
| console.log(userData); |
There was a problem hiding this comment.
Unexpected console statement no-console
|
|
||
| export { | ||
| googleStrategy, facebookStrategy, twitterStrategy, SerializeSetUp | ||
| }; |
There was a problem hiding this comment.
Unexpected line break before this closing brace object-curly-newline
| }); | ||
| }; | ||
|
|
||
| export { |
There was a problem hiding this comment.
Unexpected line break after this opening brace object-curly-newline
test/socialLogin.test.js
Outdated
| .reply(200, 'Facebook connection established'); | ||
|
|
||
| describe('passport strategy', () => { | ||
| it('should be a function', (done) => { |
There was a problem hiding this comment.
'done' is defined but never used no-unused-vars
test/socialLogin.test.js
Outdated
|
|
||
| const accessToken = 'vubhjnklmewrtyu'; | ||
| const refreshToken = 'jhvbknhjnkmknkl'; | ||
| const profile = { |
There was a problem hiding this comment.
'profile' is assigned a value but never used no-unused-vars
test/socialLogin.test.js
Outdated
| import app from '../src/server'; | ||
|
|
||
| const accessToken = 'vubhjnklmewrtyu'; | ||
| const refreshToken = 'jhvbknhjnkmknkl'; |
There was a problem hiding this comment.
'refreshToken' is assigned a value but never used no-unused-vars
test/socialLogin.test.js
Outdated
| import { socialCallBack } from '../src/helpers/helpers'; | ||
| import app from '../src/server'; | ||
|
|
||
| const accessToken = 'vubhjnklmewrtyu'; |
There was a problem hiding this comment.
'accessToken' is assigned a value but never used no-unused-vars
test/mockStrategy.js
Outdated
| passport.use(new MockStrategy('google', socialCallBack, randomSocialUser)); | ||
| passport.use( | ||
| new MockStrategy('facebook', socialCallBack, randomSocialUser) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
test/mockStrategy.js
Outdated
| } | ||
|
|
||
| passport.use(new MockStrategy('google', socialCallBack, randomSocialUser)); | ||
| passport.use( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| import config from './db/config/config'; | ||
| import { | ||
| googleStrategy, facebookStrategy, twitterStrategy, SerializeSetUp | ||
| } from './config/social_config'; |
There was a problem hiding this comment.
Unexpected line break before this closing brace object-curly-newline
| import config from './db/config/config'; | ||
| import { |
There was a problem hiding this comment.
Unexpected line break after this opening brace object-curly-newline
install passport install passport-facebook install passport-google-oauth20 install passport-twitter initialise passport strategies [#166841012]
install passport install passport-facebook install passport-google-oauth20 install passport-twitter initialise passport strategies [#166841012]
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
src/controllers/socialController.js
Outdated
|
|
||
| if (displayName) { | ||
| firstname = displayName.split(' ')[0]; | ||
| lastname = displayName.split(' ')[0]; |
There was a problem hiding this comment.
Use array destructuring prefer-destructuring
src/controllers/socialController.js
Outdated
| const { displayName } = userData; | ||
|
|
||
| if (displayName) { | ||
| firstname = displayName.split(' ')[0]; |
There was a problem hiding this comment.
Use array destructuring prefer-destructuring
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
| @@ -0,0 +1,68 @@ | |||
| import chai, { expect } from 'chai'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
test/mockUser.js
Outdated
| @@ -0,0 +1,16 @@ | |||
| import faker from 'faker'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
| import config from './db/config/config'; | ||
| import { | ||
| googleStrategy, facebookStrategy, twitterStrategy, gitHubStrategy, SerializeSetUp | ||
| } from './config/social_config'; |
There was a problem hiding this comment.
Unexpected line break before this closing brace object-curly-newline
| import config from './db/config/config'; | ||
| import { |
There was a problem hiding this comment.
Unexpected line break after this opening brace object-curly-newline
| @@ -0,0 +1,24 @@ | |||
| import { Router } from 'express'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
| @@ -0,0 +1,22 @@ | |||
| import jwt from 'jsonwebtoken'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
| @@ -0,0 +1,84 @@ | |||
| import { User } from '../db/models'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
|
|
||
| export { | ||
| googleStrategy, facebookStrategy, twitterStrategy, gitHubStrategy, SerializeSetUp | ||
| }; |
There was a problem hiding this comment.
Unexpected line break before this closing brace object-curly-newline
| }); | ||
| }; | ||
|
|
||
| export { |
There was a problem hiding this comment.
Unexpected line break after this opening brace object-curly-newline
| @@ -0,0 +1,36 @@ | |||
| import passport from 'passport'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
| @@ -0,0 +1,16 @@ | |||
| import faker from 'faker'; | |||
There was a problem hiding this comment.
Definition for rule 'jsx-a11y/anchor-is-valid' was not found jsx-a11y/anchor-is-valid
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…into ft-Enable-Social-Login-166841012
…/andela/ah-nyati-backend into ft-Enable-Social-Login-166841012
Alpha1202
force-pushed
the
ft-Enable-Social-Login-166841012
branch
from
178180b
to
30f17f0
Compare
| done(); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Trailing spaces not allowed no-trailing-spaces
| }); | ||
| }; | ||
| return Follow; | ||
| }; |
There was a problem hiding this comment.
Expected indentation of 0 spaces but found 2 indent
Newline required at end of file but not found eol-last
| onUpdate: 'CASCADE' | ||
| }); | ||
| }; | ||
| return Follow; |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| onDelete: 'CASCADE', | ||
| onUpdate: 'CASCADE' | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| foreignKey: 'id', | ||
| onDelete: 'CASCADE', | ||
| onUpdate: 'CASCADE' | ||
| }); |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 6 indent
| type: DataTypes.STRING, | ||
| required: true | ||
| }, | ||
| }, {}); |
There was a problem hiding this comment.
Expected indentation of 2 spaces but found 4 indent
| followId: { | ||
| type: DataTypes.STRING, | ||
| required: true | ||
| }, |
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 6 indent
| const Follow = sequelize.define('Follow', { | ||
| followId: { | ||
| type: DataTypes.STRING, | ||
| required: true |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 8 indent
| module.exports = (sequelize, DataTypes) => { | ||
| const Follow = sequelize.define('Follow', { | ||
| followId: { | ||
| type: DataTypes.STRING, |
There was a problem hiding this comment.
Expected indentation of 6 spaces but found 8 indent
| @@ -0,0 +1,17 @@ | |||
| module.exports = (sequelize, DataTypes) => { | |||
| const Follow = sequelize.define('Follow', { | |||
| followId: { | |||
There was a problem hiding this comment.
Expected indentation of 4 spaces but found 6 indent
|
|
||
| const gitHubStrategy = new GitHubStrategy(githubConfig, socialCallBack); | ||
|
|
||
| const SerializeSetUp = () => { |
There was a problem hiding this comment.
please document this function (jsdocs)
|
|
||
|
|
||
| let firstName, lastName; | ||
| let lName; |
There was a problem hiding this comment.
Line 27 and 28, can be just a single line
| social: userData.provider | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
Please remove all white spaces
What does this PR do?
Integrate Social Login for google, facebook and twitter
Description of Task to be completed?
Have the following endpoints working
GET /api/auth/googleGET /api/auth/facebookGET /api/auth/twitterHow should this be manually tested?
After cloning the repo, cd into the folder and RUN
npm run start:devAny background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: