Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#167222364 Get single article #40

Merged
merged 1 commit into from
Jul 23, 2019
Merged

#167222364 Get single article #40

merged 1 commit into from
Jul 23, 2019

Conversation

Cavdy
Copy link
Contributor

@Cavdy Cavdy commented Jul 11, 2019

What does this PR do?

  • Get single article

Description of Task to be completed?

  • go to api/v1/article/article-slug-name

How should this be manually tested?

  • N/A

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

  • N/A

Questions:

  • N/A

hound[bot]
hound bot reviewed Jul 11, 2019
View reviewed changes
test/articletest.js Outdated
import chai, { expect } from 'chai';
import dotenv from 'dotenv';

import { User } from '../src/db/models';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'User' is defined but never used no-unused-vars

@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 11, 2019 23:28 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 486112a to 027dc07 Compare July 14, 2019 10:12
hound[bot]
hound bot reviewed Jul 14, 2019
View reviewed changes
src/helpers/findItem.js Outdated
@@ -0,0 +1,37 @@
import { User, Article } from '../db/models';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'User' is defined but never used no-unused-vars

@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 14, 2019 10:13 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 027dc07 to d1a4185 Compare July 16, 2019 15:09
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 16, 2019 15:09 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from d1a4185 to ed6a0d2 Compare July 16, 2019 15:16
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 16, 2019 15:17 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from ed6a0d2 to dc5d21a Compare July 16, 2019 15:21
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 16, 2019 15:22 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from dc5d21a to 076bfbf Compare July 16, 2019 15:34
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 16, 2019 15:34 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 076bfbf to 92b126f Compare July 17, 2019 14:30
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 17, 2019 14:30 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 92b126f to 98ff7b4 Compare July 17, 2019 14:58
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 17, 2019 14:58 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 98ff7b4 to 802e1b2 Compare July 17, 2019 16:11
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 17, 2019 16:12 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 802e1b2 to f8b471f Compare July 19, 2019 18:24
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 19, 2019 18:25 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from f8b471f to ef20b86 Compare July 19, 2019 18:54
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 19, 2019 18:54 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from ef20b86 to 7eaf96b Compare July 22, 2019 14:39
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 22, 2019 14:40 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 7eaf96b to 948d4fb Compare July 22, 2019 14:56
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 22, 2019 14:56 Inactive
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 948d4fb to 1e312c5 Compare July 22, 2019 16:25
@czarjulius czarjulius temporarily deployed to ah-nyati-backend-staging-pr-40 July 22, 2019 16:25 Inactive
@Cavdy
feature(get single article):get single article
b2d0019 
get single article
[finishes #167222364]
@Cavdy Cavdy force-pushed the ft-get-single-article-167222364 branch from 1e312c5 to b2d0019 Compare July 22, 2019 16:31
codeBlock-1984
codeBlock-1984 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@codeBlock-1984 codeBlock-1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Cavdy.

@Cavdy Cavdy merged commit 227fd30 into staging Jul 23, 2019
@Cavdy Cavdy deleted the ft-get-single-article-167222364 branch July 23, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

@phembarl phembarl phembarl approved these changes

@codeBlock-1984 codeBlock-1984 codeBlock-1984 approved these changes

@chokonaira chokonaira chokonaira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Cavdy @phembarl @codeBlock-1984 @chokonaira @czarjulius