#167970785 Implement redirection to frontend (social) #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
test/socialLogin.test.js
Outdated
| @@ -48,6 +49,7 @@ describe('GET Social Login', () => { | |||
| }; | |||
| sinon.stub(User, 'findOrCreate').returns(dbResponse); | |||
| await socialController.socialUser(request, response); | |||
| console.log(response); | |||
There was a problem hiding this comment.
Unexpected console statement no-console
test/socialLogin.test.js
Outdated
| @@ -38,6 +38,7 @@ describe('GET Social Login', () => { | |||
| }; | |||
| sinon.stub(User, 'findOrCreate').returns(dbResponse); | |||
| await socialController.socialUser(request, response); | |||
| console.log(response); | |||
There was a problem hiding this comment.
Unexpected console statement no-console
- Implement redirection to frontend url - Change backend port to prevent conflict [Delivers #167970785]
codeBlock-1984
force-pushed
the
bg-redirection-social-callback-167970785
branch
from
b5aba23
to
d20817b
Compare
czarjulius
approved these changes
Aug 21, 2019
Cavdy
approved these changes
Aug 21, 2019
Alpha1202
approved these changes
Aug 21, 2019
chokonaira
approved these changes
Aug 21, 2019
phembarl
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions: