Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16539380 Fix heroku build #20

Merged
merged 1 commit into from
Apr 17, 2019
Merged

#16539380 Fix heroku build #20

merged 1 commit into from
Apr 17, 2019

Conversation

Kibetchirchir
Copy link
Contributor

@Kibetchirchir Kibetchirchir commented Apr 16, 2019 •
edited
Loading

Description

  • Fixes heroku build implement npm packages installment

Type of change

Please select the relevant option

  • Bug fix(a non-breaking change which fixes an issue)
  • New feature(a non-breaking change which adds functionality)
  • Breaking change(fix of feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes

  • End to end test
  • Integration test
  • unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Related Pivotal Tracker stories

165079446

Reviewers

  • @andela/olympian-devs
  • @anyotherreviwer
  • @anyotherreviwer

Relevant screenshots:

image

@Kibetchirchir
165393804-bug(package.json): Fux heroku build
5f4f78d 
- Fixes heroku build
- implement npm packages installment

[Finishes #165393804]
mnswaleh
mnswaleh approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@mnswaleh mnswaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit PR name

@Kibetchirchir Kibetchirchir changed the title 165393804-bug(package.json): Fux heroku build #16539380 Fix heroku build Apr 17, 2019
@Derrickkip Derrickkip merged commit 52e3261 into develop Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derrickkip Derrickkip Derrickkip approved these changes

@mnswaleh mnswaleh mnswaleh approved these changes

@kevpy kevpy Awaiting requested review from kevpy

@JumaKahiga JumaKahiga Awaiting requested review from JumaKahiga

@winniekariuki winniekariuki Awaiting requested review from winniekariuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kibetchirchir @Derrickkip @mnswaleh