Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

165810050-fix(login): fixes login bug :work-in-progress: #30

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Kibetchirchir
Copy link
Contributor

Description

This pull request fixes the login bug.

How can This be tested

Clone the repo then:

  • checkout to this branch
  • do npm install
  • do npm install -g npm-install-peers
  • do npm run coverage
  • do npm start

Type of change

Please select the relevant option

  • Bug fix(a non-breaking change which fixes an issue)
  • New feature(a non-breaking change which adds functionality)
  • Breaking change(fix of feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes

  • End to end test
  • Integration test
  • unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Related Pivotal Tracker stories

#165079446

Reviewers

  • @andela/olympian-devs
  • @anyotherreviwer
  • @anyotherreviwer

Relevant screenshots:

- ensure the user information in the user storage

[Fixes #165810050]
@Kibetchirchir Kibetchirchir changed the title 165810050-fix(login): fixes login bug 165810050-fix(login): fixes login bug :work-in-progress: May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant