Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#164047059 User should verify his email #11

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

Kibetchirchir
Copy link
Contributor

@Kibetchirchir Kibetchirchir commented Mar 4, 2019

Description


When a user signs up, he/she should be able to recieve a verification email to the email specified. The token is then sent to the endpoint to be verified

Type of Change


  • New Feature

How has this been tested


  • Unit tests
  • End to end testing

Checklist


  • I have added tests that prove my feature is working

Pivotal Tracker


164047059

@kelvinndmo
Copy link
Contributor

@Kibetchirchir take note of some conflicting files

@Kibetchirchir Kibetchirchir force-pushed the ft-send-verification-164047059 branch from b13a8af to 1c6b800 Compare March 5, 2019 08:20
feature
- ensures user receives an email once he/she signs up
- ensures user email is validated using a token
- adds .env.example field for the upodated envs

[Finishes #164047059]
@Kibetchirchir Kibetchirchir force-pushed the ft-send-verification-164047059 branch from 1c6b800 to 6438bd2 Compare March 5, 2019 09:16
@kelvinndmo
Copy link
Contributor

Resolved @Kibetchirchir ... some good work, like the way you have followed pep8 principles.

@winniekariuki
Copy link
Contributor

Nice formating

@JumaKahiga
Copy link
Collaborator

Great work. Thanks for handling SendGrid integration.

Copy link
Contributor

@JoanNgatia JoanNgatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanNgatia JoanNgatia merged commit 3941cd7 into develop Mar 6, 2019
@JoanNgatia JoanNgatia deleted the ft-send-verification-164047059 branch March 8, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants