#164047056 Add CORS- origin #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kibetchirchir
force-pushed
the
fix-CROS-origin-164047056
branch
from
0bb6c06
to
970f908
Compare
Kibetchirchir
changed the title
|
Thanks for working on this issue Chirchir. |
Kibetchirchir
force-pushed
the
fix-CROS-origin-164047056
branch
from
970f908
to
0538343
Compare
JoanNgatia
suggested changes
Apr 2, 2019
requirements.txt
Outdated
| @@ -37,6 +40,8 @@ MarkupSafe==1.1.1 | |||
| mccabe==0.6.1 | |||
| mock==2.0.0 | |||
| more-itertools==6.0.0 | |||
| mypy==0.670 | |||
There was a problem hiding this comment.
Do we need the libraries mypy, mypy-extensions, typed-ast and typing-extensions for this feature fix?
If they didn't get added by installing some of the other libraries, then we can remove them.
- Add CORS origin [Fixes #164047075]
Kibetchirchir
force-pushed
the
fix-CROS-origin-164047056
branch
from
0538343
to
4a5d4be
Compare
JoanNgatia
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user can be able to consume the API without getting CROS origin error
Type of Change
How has this been tested
Checklist
Pivotal Tracker
164047056