Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in coveralls #10

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Fix bug in coveralls #10

merged 1 commit into from
Nov 29, 2018

Conversation

evamaina
Copy link
Contributor

@evamaina evamaina commented Nov 29, 2018

What does this PR do?

This PR fixes a bug in coveralls

Description of Task to be completed?

add the correct script for coveralls in package.json file

How should this be manually tested?

https://github.com/andela/ah-orcas-frontend
switch to bg-fix-coveralls-bug
Check the README file

Any background context you want to provide?

once this branch is merged to develop, the current coverage will display on the badge

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

- Fix bug in coveralls
@codeclimate
Copy link

codeclimate bot commented Nov 29, 2018

Code Climate has analyzed commit 6872a67 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@abadojack abadojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TheSteelGuy TheSteelGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gidraf Gidraf merged commit 991512b into develop Nov 29, 2018
@Gidraf Gidraf deleted the bg-fix-coveralls-bug branch November 29, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants