Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161254665 Add comments to articles #32

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

wrotich
Copy link
Contributor

@wrotich wrotich commented Nov 13, 2018

What does this PR do?

This PR merges the add comments feature branch to develop

Description of Task to be completed?

- Allow users to comment on articles
- Allow users to view all comments of an article
- Allow users to delete comments on articles
- Allow users to comment on other comments

How should this be manually tested?

  • create a python virtual environment in your local machine and start it.
$ virtualenv env
$ source env/bin/activate
$ cd env
  • Clone this repo.
$ git clone https://github.com/andela/ah-orcas.git
  • Switch to this branch
$  git checkout  ft-article-161254665
  • Create a .env file and run it. Check sample.env file to configure yours.
$ source .env
  • Run the app
$ python manage.py runserver
  • Test the endpoint as per the README.md

Any background context you want to provide?

Comments allow authors to get feedback on their articles.

What are the relevant pivotal tracker stories?

#161254665

Screenshots

  • A comment with replies

screen shot 2018-11-14 at 13 14 38

@wrotich wrotich added the wip work in progress label Nov 13, 2018
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/tests/test_article_comments.py Outdated Show resolved Hide resolved
authors/apps/article/tests/test_article_comments.py Outdated Show resolved Hide resolved
authors/apps/article/tests/test_article_comments.py Outdated Show resolved Hide resolved
authors/apps/article/tests/test_article_comments.py Outdated Show resolved Hide resolved
authors/apps/article/tests/test_article_comments.py Outdated Show resolved Hide resolved
@wrotich wrotich force-pushed the ft-article-comments-161254665 branch from ab8bba0 to 37cbb81 Compare November 13, 2018 13:09
@wrotich wrotich force-pushed the ft-article-comments-161254665 branch from 37cbb81 to 226feff Compare November 13, 2018 13:23
@wrotich wrotich force-pushed the ft-article-comments-161254665 branch 3 times, most recently from 0dd1576 to d2a9df2 Compare November 13, 2018 14:12
authors/apps/article/views.py Outdated Show resolved Hide resolved
authors/apps/article/views.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 13, 2018

Pull Request Test Coverage Report for Build 575

  • 105 of 116 (90.52%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 87.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
authors/apps/article/models.py 8 9 88.89%
authors/apps/article/renderers.py 12 13 92.31%
authors/apps/article/serializers.py 32 36 88.89%
authors/apps/article/views.py 53 58 91.38%
Totals Coverage Status
Change from base Build 569: 0.3%
Covered Lines: 801
Relevant Lines: 911

💛 - Coveralls

@wrotich wrotich force-pushed the ft-article-comments-161254665 branch 3 times, most recently from bc39b17 to 849f626 Compare November 14, 2018 07:36
@Gidraf
Copy link
Contributor

Gidraf commented Nov 14, 2018

Add tests to improve the coverage

Copy link
Contributor

@Gidraf Gidraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to improve the coverage
solve the merging conflict

@wrotich wrotich force-pushed the ft-article-comments-161254665 branch from abf92a0 to 63f34ce Compare November 14, 2018 09:49
- enable users to add comments to articles
- enable users to comment on other comments
- add tests for comments
- fix failing travis build
- fix hound issues
- fix codeclimate issues

[Delivers #161254665]
@wrotich wrotich force-pushed the ft-article-comments-161254665 branch from 63f34ce to 9552411 Compare November 14, 2018 10:01
@wrotich wrotich added Finished and removed wip work in progress labels Nov 14, 2018
Copy link
Contributor

@evamaina evamaina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eyansky Eyansky self-requested a review November 14, 2018 11:24
Copy link
Contributor

@Eyansky Eyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@code-sleuth code-sleuth merged commit db6e646 into develop Nov 14, 2018
@code-sleuth code-sleuth deleted the ft-article-comments-161254665 branch November 14, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants