Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161254678 share articles across different channels #33

Merged
merged 1 commit into from
Nov 13, 2018
Merged

#161254678 share articles across different channels #33

merged 1 commit into from
Nov 13, 2018

Conversation

evamaina
Copy link
Contributor

What does this PR do?

This PR implements feature to enable sharing of articles across different channels such as facebook, twitter, LinkedIn and mail

Description of Task to be completed?

  • Implement feature to enable sharing of articles via social media
  • The return JSON output will include links for twitter, facebook linked and mail

How should this be manually tested?

  • Clone this repo:
    git clone https://github.com/andela/ah-orcas
  • Navigate to this branch
    git checkout ft-pagination-161254678
  • Setup the environment variables, database and install the requirements.
    $ source .env
  • Start the server
    $ python manage.py runserver
  • Hit the GET endpoint in the postman
    Run in Postman

What are the relevant pivotal tracker stories?

#161254678

Screenshots

image
image
image
image
image
image

@evamaina evamaina added the wip work in progress label Nov 13, 2018
houndci-bot
houndci-bot reviewed Nov 13, 2018
View reviewed changes
authors/apps/article/tests/test_article.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
codeclimate[bot]
codeclimate bot reviewed Nov 13, 2018
View reviewed changes
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
authors/apps/article/serializers.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 519

  • 33 of 33 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 87.337%
Totals Coverage Status
Change from base Build 511: 0.6%
Covered Lines: 669
Relevant Lines: 766
💛 - Coveralls

@evamaina evamaina force-pushed the ft-share-articles-161254678 branch 4 times, most recently from 7ae638c to 8373b26 Compare November 13, 2018 10:54
abadojack
abadojack suggested changes Nov 13, 2018
View reviewed changes
authors/apps/article/serializers.py Outdated Show resolved Hide resolved
@evamaina
feat(share articles): share articles across different channels
6912bcb 
- enable sharing of articles across different channels
- rebase

[Delivers #161254678]
@evamaina evamaina added Finished and removed wip work in progress labels Nov 13, 2018
abadojack
abadojack approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@abadojack abadojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TheSteelGuy
TheSteelGuy approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@TheSteelGuy TheSteelGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@code-sleuth code-sleuth merged commit 9637c6e into develop Nov 13, 2018
@code-sleuth code-sleuth deleted the ft-share-articles-161254678 branch November 13, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@codeclimate codeclimate[bot] codeclimate left review comments

@abadojack abadojack abadojack approved these changes

@TheSteelGuy TheSteelGuy TheSteelGuy approved these changes

@code-sleuth code-sleuth Awaiting requested review from code-sleuth

@Gidraf Gidraf Awaiting requested review from Gidraf

@kipropbrian kipropbrian Awaiting requested review from kipropbrian

Assignees
No one assigned
Labels
Finished
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@evamaina @coveralls @houndci-bot @abadojack @TheSteelGuy @code-sleuth