#161254679 create, delete bookmark #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 15, 2018
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 693
💛 - Coveralls |
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
from
357c836
to
23db497
Compare
houndci-bot
reviewed
Nov 15, 2018
| from .models import Bookmark | ||
|
|
||
|
|
||
| class BookmarkAPIView(APIView): |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
2 times, most recently
from
7778756
to
1b8f5f1
Compare
| renderer_classes = (BookmarkJSON,) | ||
| queryset = Bookmark.objects.all() | ||
|
|
||
| def post(self, request, slug): |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| data["message"] = "bookmarked" | ||
| return Response(data, status.HTTP_200_OK) | ||
|
|
||
| def delete(self, request, slug): |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
from
1b8f5f1
to
619debb
Compare
houndci-bot
reviewed
Nov 16, 2018
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
2 times, most recently
from
0f4a2d3
to
d01cecb
Compare
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
from
d01cecb
to
231dcb0
Compare
houndci-bot
reviewed
Nov 16, 2018
- user can create bookmark - user can delete bookmark [Delivers #161254679]
Eyansky
force-pushed
the
ft-bookmarks-161254679
branch
from
231dcb0
to
02d503e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
#161254679
Screenshots (if appropriate)