-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#167515607 Change Unit Testing to Use Mocha and Chai #10
Conversation
@@ -0,0 +1,19 @@ | |||
import chai from 'chai'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
61a77f2
to
bf6f804
Compare
bf6f804
to
b754486
Compare
setup unit test using mocha-chai [Finishes #167515607]
b754486
to
77bc767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Korede
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code looks good to me. Well done
@@ -1,29 +1,19 @@ | |||
{ | |||
"name": "Rambo-AuthorsHaven", | |||
"name": "rambo-authors-haven", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint was flagging it as an error will send you the screenshot
What does this PR do?
This PR implements unit test using mocha and chai.
This chore is raised to enable serving the swagger API-docs via the API URL which was problematic in jest
Description of Task proposed in this pull request?
The unit test which was performed using Jest was replaced with mocha-chai
How should this be manually tested (Quality Assurance)?
What are the relevant pivotal tracker stories?
Any background context you want to add (Operations Impact)?
npm install
What I have learned working on this feature:
mocha
andchai