Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167515607 Change Unit Testing to Use Mocha and Chai #10

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

Adekoreday
Copy link
Contributor

@Adekoreday Adekoreday commented Jul 25, 2019

What does this PR do?

This PR implements unit test using mocha and chai.
This chore is raised to enable serving the swagger API-docs via the API URL which was problematic in jest

Description of Task proposed in this pull request?

The unit test which was performed using Jest was replaced with mocha-chai

How should this be manually tested (Quality Assurance)?

npm test

What are the relevant pivotal tracker stories?

Any background context you want to add (Operations Impact)?

npm install

What I have learned working on this feature:

  • I learnt how to set up the unit test using mocha and chai

@Adekoreday Adekoreday added the pr:wip PR is still a work in progress label Jul 25, 2019
@@ -0,0 +1,19 @@
import chai from 'chai';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

@Adekoreday Adekoreday removed the pr:wip PR is still a work in progress label Jul 25, 2019
@Adekoreday Adekoreday force-pushed the ft-setup-unit-test-mocha-167515607 branch from 61a77f2 to bf6f804 Compare July 25, 2019 16:56
@Adekoreday Adekoreday changed the title chore-[167515607]:setup unit test #167515607 Setup Unit Test Jul 25, 2019
@Adekoreday Adekoreday force-pushed the ft-setup-unit-test-mocha-167515607 branch from bf6f804 to b754486 Compare July 25, 2019 17:03
setup unit test using mocha-chai

[Finishes #167515607]
@Adekoreday Adekoreday force-pushed the ft-setup-unit-test-mocha-167515607 branch from b754486 to 77bc767 Compare July 25, 2019 17:11
@Adekoreday Adekoreday added pr:review This is PR is currently under review by team type:chore Changes that don't modify business code labels Jul 25, 2019
@Adekoreday Adekoreday changed the title #167515607 Setup Unit Test #167515607 Setup Unit Test using mocha-chai Jul 25, 2019
@Adekoreday Adekoreday removed the request for review from dinobi July 25, 2019 17:35
Copy link
Contributor

@chialuka chialuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Korede

Copy link
Contributor

@abdulfatai360 abdulfatai360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks good to me. Well done

@dinobi dinobi added the type:ci changes to CI configuration label Jul 25, 2019
@dinobi dinobi changed the title #167515607 Setup Unit Test using mocha-chai #167515607 Change Unit Testing to Use Mocha and Chai Jul 25, 2019
@@ -1,29 +1,19 @@
{
"name": "Rambo-AuthorsHaven",
"name": "rambo-authors-haven",
Copy link
Contributor

@dinobi dinobi Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint was flagging it as an error will send you the screenshot

@dinobi dinobi merged commit 93de2a7 into develop Jul 25, 2019
@dinobi dinobi deleted the ft-setup-unit-test-mocha-167515607 branch July 26, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:review This is PR is currently under review by team type:chore Changes that don't modify business code type:ci changes to CI configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants