#167574878 Facebook Social Login #17

Adekoreday · 2019-07-31T13:36:03Z

Enable Social Login using facebook

What does this PR do?

This PR enables social authentication using facebook

Description of Task proposed in this pull request?

enables social login using facebook
ensure optimum test coverage

How should this be manually tested (Quality Assurance)?

npm install
npm run start: dev (for development server)

open your browser and navigate to 
http://localhost:5000/api/v1/auth/facebook
A dialogue prompting a user to authenticate their account via facebook
On authentication, the user would be created and their details returned. via a browser window
as shown below

What are the relevant pivotal tracker stories?

167574878

Any background context you want to add (Operations Impact)?

Ensure the localhost port = 5000, as this is the only port recognized by facebook in our configurations
Ensure the REDIRECT_URL= to the exact address in the .env.sample file
add the following in the .env file
FACEBOOK_APP_ID=
FACEBOOK_APP_SECRET=
REDIRECT_URL=http://localhost:5000/api/v1/auth/facebook/callback

What I have learned working on this feature:

I learned how to enable facebook login using passport.js
I learned how to stub functions using sinon.js

Screenshots:

hound · 2019-07-31T13:36:08Z

server/database/migrations/20190729180949-create-user.js

@@ -0,0 +1,28 @@
+export default {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:14Z

test/user/socialLogin.test.js

@@ -0,0 +1,43 @@
+import chai from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:15Z

test/user/index.test.js

@@ -0,0 +1,3 @@
+import socialLogin from './socialLogin.test';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:15Z

server/routes/index.js

@@ -0,0 +1,8 @@
+import express from 'express';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:15Z

server/routes/auth.js

@@ -0,0 +1,17 @@
+import express from 'express';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:15Z

server/helpers/passportError.js

@@ -0,0 +1,4 @@
+export default (error, req, res, next) => {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:15Z

server/helpers/passport.js

@@ -0,0 +1,16 @@
+import passport from 'passport';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:16Z

server/helpers/facebook.js

@@ -0,0 +1,16 @@
+import passport from 'passport';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:16Z

server/helpers/SocialAuth.js

@@ -0,0 +1,31 @@
+/* eslint-disable require-jsdoc */
+import Debug from 'debug';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-07-31T13:36:16Z

server/database/models/user.js

@@ -0,0 +1,12 @@
+export default (sequelize, DataTypes) => {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-08-01T17:18:23Z

server/index.js

+    resave: true,
+    saveUninitialized: true
+  })
+);


Unexpected newline before ')' function-paren-newline

hound · 2019-08-01T17:18:23Z

server/index.js

@@ -22,6 +21,13 @@ app.use(logger('dev'));
 app.use(json());
 app.use(urlencoded({ extended: false }));
 app.use('/api-docs', swaggerUi.serve, swaggerUi.setup(swaggerDoc));
+app.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-01T17:18:23Z

server/helpers/facebook.js

+        cb(null, profile);
+      }
+    )
+  );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-01T17:18:23Z

server/helpers/facebook.js

+import { Strategy as FacebookStrategy } from 'passport-facebook';
+
+export default () => {
+  passport.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-01T19:20:10Z

test/auth/__mocks_/facebookLogin.test.js

+    serialize = sinon.stub(passport, 'serializeUser').yields({}, () => {});
+    deserialize = sinon.stub(passport, 'deserializeUser').yields({}, () => {});
+    sinons = sinon.stub(User, 'findOne').returns(false);
+    passportUse = sinon.stub(passport, 'use').callsFake(({}) => {});


Unexpected empty object pattern no-empty-pattern

hound · 2019-08-01T19:20:11Z

server/helpers/passportCallback.js

+ * @param {function} done express next function
+ * @returns {JSON} JSON object with details of new user
+ */
+const callback = (accessToken, refreshToken, profile, done) => done(null, profile);


Line 11 exceeds the maximum line length of 80 max-len

hound · 2019-08-01T19:32:12Z

test/auth/__mocks_/facebookLogin.test.js

+
+const { expect } = chai;
+chai.use(chaiHttp);
+let serialize, deserialize, sinons, passportUse;


'passportUse' is defined but never used. Allowed unused vars must match /should|expect/ no-unused-vars

hound · 2019-08-02T14:00:33Z

server/controllers/Auth.js

+        userName: givenName
+      }
+    });
+    console.log('my users', users);


Unexpected console statement no-console

hound · 2019-08-02T14:00:33Z

server/controllers/Auth.js

+import {
+  generateToken,
+  serverResponse,
+  serverError,


'serverError' is defined but never used. Allowed unused vars must match /should|expect/ no-unused-vars

hound · 2019-08-02T14:00:33Z

server/controllers/Auth.js

+import models from '../database/models';
+import {
+  generateToken,
+  serverResponse,


'serverResponse' is defined but never used. Allowed unused vars must match /should|expect/ no-unused-vars

hound · 2019-08-02T18:22:49Z

server/middlewares/passportCallback.js

+ * @param {function} done express next function
+ * @returns {JSON} JSON object with details of new user
+ */
+const callback = (accessToken, refreshToken, profile, done) => done(null, profile);


Line 9 exceeds the maximum line length of 80 max-len

hound · 2019-08-05T12:10:10Z

server/helpers/getSocialUserData.js

+ * @returns {Object} facebookUserData with details of new user
+ */
+const facebookData = (request) => {
+  const { email } = request.user._json;


Unexpected dangling '_' in '_json' no-underscore-dangle

dinobi · 2019-08-05T13:39:49Z

server/controllers/Auth.js

+      userAgent,
+      ipAddress: ip
+    };
+    const Data = await createSocialUsers(data);


Data -> user

noted thanks

#167573212 Implement Login Feature

dinobi

@Adekoreday please be aware that this code will be refactored entirely when implementing Google and Twitter, because the logic will remain the same asides how we retrieve user data from the payload returned by passport callback. Please always think in the big picture when implementing solutions.

hound bot reviewed Jul 31, 2019

View reviewed changes

Adekoreday added the pr:wip PR is still a work in progress label Jul 31, 2019

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch 3 times, most recently from 072b15f to 070a327 Compare August 1, 2019 17:18

hound bot reviewed Aug 1, 2019

View reviewed changes

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from 070a327 to f7f1600 Compare August 1, 2019 19:20

hound bot reviewed Aug 1, 2019

View reviewed changes

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from f7f1600 to 08c31bd Compare August 1, 2019 19:32

hound bot reviewed Aug 1, 2019

View reviewed changes

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch 2 times, most recently from 24133b0 to 38d5436 Compare August 1, 2019 19:35

Adekoreday added pr:review This is PR is currently under review by team and removed pr:wip PR is still a work in progress labels Aug 1, 2019

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from 38d5436 to 6cd00cd Compare August 1, 2019 19:55

Adekoreday added pr:wip PR is still a work in progress and removed pr:review This is PR is currently under review by team labels Aug 2, 2019

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from 6cd00cd to e5f011d Compare August 2, 2019 14:00

hound bot reviewed Aug 2, 2019

View reviewed changes

Adekoreday added pr:review This is PR is currently under review by team and removed pr:wip PR is still a work in progress labels Aug 2, 2019

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch 2 times, most recently from 1842077 to 98a95ee Compare August 2, 2019 17:21

Adekoreday added pr:wip PR is still a work in progress and removed pr:review This is PR is currently under review by team labels Aug 2, 2019

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from 98a95ee to e722d24 Compare August 2, 2019 18:22

hound bot reviewed Aug 2, 2019

View reviewed changes

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from e722d24 to 985de51 Compare August 2, 2019 18:31

Adekoreday removed the pr:wip PR is still a work in progress label Aug 2, 2019

Adekoreday closed this Aug 4, 2019

Adekoreday reopened this Aug 4, 2019

andela deleted a comment from Adekoreday Aug 4, 2019

henryade previously approved these changes Aug 5, 2019

View reviewed changes

JuwonAbiola previously approved these changes Aug 5, 2019

View reviewed changes

chialuka previously approved these changes Aug 5, 2019

View reviewed changes

Adekoreday added pr:ready This PR is ready to be merged and removed pr:review This is PR is currently under review by team labels Aug 5, 2019

Adekoreday dismissed stale reviews from chialuka, JuwonAbiola, and henryade via dcf9ec5 August 5, 2019 12:09

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from ff2b2b7 to dcf9ec5 Compare August 5, 2019 12:09

hound bot reviewed Aug 5, 2019

View reviewed changes

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch 5 times, most recently from b054fa8 to 7a0c25a Compare August 5, 2019 13:05

henryade previously approved these changes Aug 5, 2019

View reviewed changes

chialuka previously approved these changes Aug 5, 2019

View reviewed changes

JuwonAbiola previously approved these changes Aug 5, 2019

View reviewed changes

dinobi reviewed Aug 5, 2019

View reviewed changes

Adekoreday dismissed stale reviews from JuwonAbiola, chialuka, and henryade via ef869be August 5, 2019 13:44

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from 7a0c25a to ef869be Compare August 5, 2019 13:44

Merge pull request #14 from andela/ft-login-167573212

6c19aed

#167573212 Implement Login Feature

Adekoreday force-pushed the ft-social-auth-facebook-167574878 branch from ef869be to 6c19aed Compare August 5, 2019 13:51

dinobi approved these changes Aug 5, 2019

View reviewed changes

dinobi merged commit 3411542 into develop Aug 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167574878 Facebook Social Login #17

#167574878 Facebook Social Login #17

Adekoreday commented Jul 31, 2019 •

edited

Loading

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Jul 31, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 1, 2019

hound bot Aug 2, 2019

hound bot Aug 2, 2019

hound bot Aug 2, 2019

hound bot Aug 2, 2019

hound bot Aug 5, 2019

dinobi Aug 5, 2019

Adekoreday Aug 5, 2019

dinobi left a comment

		@@ -0,0 +1,3 @@
		import socialLogin from './socialLogin.test';

		@@ -0,0 +1,31 @@
		/* eslint-disable require-jsdoc */
		import Debug from 'debug';

#167574878 Facebook Social Login #17

#167574878 Facebook Social Login #17

Conversation

Adekoreday commented Jul 31, 2019 • edited Loading

What does this PR do?

Description of Task proposed in this pull request?

How should this be manually tested (Quality Assurance)?

What are the relevant pivotal tracker stories?

Any background context you want to add (Operations Impact)?

What I have learned working on this feature:

Screenshots:

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Jul 31, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 1, 2019

Choose a reason for hiding this comment

hound bot Aug 2, 2019

Choose a reason for hiding this comment

hound bot Aug 2, 2019

Choose a reason for hiding this comment

hound bot Aug 2, 2019

Choose a reason for hiding this comment

hound bot Aug 2, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

dinobi Aug 5, 2019

Choose a reason for hiding this comment

Adekoreday Aug 5, 2019

Choose a reason for hiding this comment

dinobi left a comment

Choose a reason for hiding this comment

Adekoreday commented Jul 31, 2019 •

edited

Loading