#167619168 Create Sessions Table #18

ayodejiAA · 2019-07-31T14:59:43Z

What does this PR do?

Create migration for session table
Add demo seed file

Description of Task proposed in this pull request?

Add session migration file
Add Session model
Add Session seed file

How should this be manually tested (Quality Assurance)?

Check out the branch
-Add the database connection string in .env file
Run npm run db:seed

What are the relevant pivotal tracker stories?

Story ID: #167619168

Any background context you want to add (Operations Impact)?

Requires database connection string for it to work

What I have learned working on this feature:

Use sequelize cli to generate migrations and seeds

Screenshots: [If you made some visual changes to the application please upload screenshots here, or remove this section]

n/a

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

server/database/seeds/20190731140725-demo-session.js

server/database/models/session.js

server/database/migrations/20190731135151-create-session.js

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

server/database/seeds/20190731140725-demo-session.js

server/database/models/session.js

dinobi · 2019-07-31T16:08:10Z

server/database/migrations/20190731135151-create-session.js

+      type: Sequelize.STRING
+    },
+    userAgent: {
+      allowNull: false,


allow null here

dinobi · 2019-07-31T16:08:28Z

server/database/migrations/20190731135151-create-session.js

+      type: Sequelize.DATE
+    },
+    ipAddress: {
+      allowNull: false,


allow null here

I think allow null here means that the field should be nullable, or am I wrong?

dinobi · 2019-07-31T16:09:56Z

server/database/models/session.js

+      userId: DataTypes.INTEGER,
+      active: DataTypes.BOOLEAN,
+      devicePlatform: DataTypes.STRING,
+      expiresAt: DataTypes.DATE,


Don't sequelize have a date time type?

this is datetime, confirmed.

dinobi

Please add model tests

ayodejiAA · 2019-07-31T16:24:27Z

Please add model tests

Okay. On it.

test/helpers/sessionMigration.test.js

- Create migration for session table - Add demo seed file for session details [Finishes #167619168]

ayodejiAA · 2019-07-31T19:04:33Z

Please add model tests
@dinobi Implemented the model test

chialuka · 2019-08-01T13:32:33Z

server/database/migrations/20190731135151-create-session.js

+      type: Sequelize.DATE
+    },
+    ipAddress: {
+      allowNull: false,


I think allow null here means that the field should be nullable, or am I wrong?

server/database/migrations/20190731135151-create-session.js

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

chore-[167619168]: Create sessions table

1d92ba4

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

hound bot reviewed Jul 31, 2019

View reviewed changes

chialuka temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 14:59 Inactive

ayodejiAA requested review from chialuka, abdulfatai360, Adekoreday, dinobi and henryade July 31, 2019 14:59

ayodejiAA added pr:review This is PR is currently under review by team priority:high This PR has a high priority type:chore Changes that don't modify business code labels Jul 31, 2019

chore-[167619168]: Create sessions table

eb4a8de

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

hound bot reviewed Jul 31, 2019

View reviewed changes

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 15:04 Inactive

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 3611c93 to 958ef82 Compare July 31, 2019 15:10

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 15:10 Inactive

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 958ef82 to 612accb Compare July 31, 2019 15:13

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 15:13 Inactive

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 612accb to 42ab2aa Compare July 31, 2019 15:17

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 15:17 Inactive

ayodejiAA changed the title ~~#167619168 Create sessions table~~ #167619168 Create Sessions Table Jul 31, 2019

dinobi reviewed Jul 31, 2019

View reviewed changes

dinobi suggested changes Jul 31, 2019

View reviewed changes

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 42ab2aa to 2fe96bb Compare July 31, 2019 18:49

hound bot reviewed Jul 31, 2019

View reviewed changes

test/helpers/sessionMigration.test.js Show resolved Hide resolved

test/helpers/sessionMigration.test.js Show resolved Hide resolved

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 18:49 Inactive

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 2fe96bb to 1021d4f Compare July 31, 2019 18:51

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 18:52 Inactive

chore-[167619168]: Create sessions table

d8cb777

- Create migration for session table - Add demo seed file for session details [Finishes #167619168]

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 1021d4f to d8cb777 Compare July 31, 2019 18:58

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 July 31, 2019 18:59 Inactive

ayodejiAA requested a review from dinobi July 31, 2019 19:02

ayodejiAA requested a review from JuwonAbiola August 1, 2019 01:22

henryade previously approved these changes Aug 1, 2019

View reviewed changes

ayodejiAA dismissed henryade’s stale review via 6914c9b August 1, 2019 12:20

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from d8cb777 to 6914c9b Compare August 1, 2019 12:20

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 August 1, 2019 12:21 Inactive

Adekoreday previously approved these changes Aug 1, 2019

View reviewed changes

chialuka reviewed Aug 1, 2019

View reviewed changes

ayodejiAA dismissed Adekoreday’s stale review via f3f7b32 August 1, 2019 13:56

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from 6914c9b to f3f7b32 Compare August 1, 2019 13:56

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 August 1, 2019 13:56 Inactive

ayodejiAA requested review from chialuka, henryade and Adekoreday August 1, 2019 13:58

chore-[167619168]: Create sessions table

84febf5

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

ayodejiAA force-pushed the ch-create-session-table-167619168 branch from f3f7b32 to 84febf5 Compare August 1, 2019 14:09

ayodejiAA temporarily deployed to authors-haven-developmen-pr-18 August 1, 2019 14:09 Inactive

chore-[167619168]: Create sessions table

415e9c8

- Create migration from session table - Add demo seed file for session details [Finishes #167619168]

ayodejiAA deployed to authors-haven-developmen-pr-18 August 1, 2019 14:32 View deployment

dinobi approved these changes Aug 1, 2019

View reviewed changes

dinobi merged commit 452b993 into develop Aug 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167619168 Create Sessions Table #18

#167619168 Create Sessions Table #18

ayodejiAA commented Jul 31, 2019 •

edited

Loading

dinobi Jul 31, 2019

ayodejiAA Jul 31, 2019

dinobi Jul 31, 2019

ayodejiAA Jul 31, 2019

chialuka Aug 1, 2019

dinobi Jul 31, 2019

dinobi Jul 31, 2019

dinobi left a comment

ayodejiAA commented Jul 31, 2019

ayodejiAA commented Jul 31, 2019

chialuka Aug 1, 2019

#167619168 Create Sessions Table #18

#167619168 Create Sessions Table #18

Conversation

ayodejiAA commented Jul 31, 2019 • edited Loading

What does this PR do?

Description of Task proposed in this pull request?

How should this be manually tested (Quality Assurance)?

What are the relevant pivotal tracker stories?

Any background context you want to add (Operations Impact)?

What I have learned working on this feature:

Screenshots: [If you made some visual changes to the application please upload screenshots here, or remove this section]

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dinobi left a comment

Choose a reason for hiding this comment

ayodejiAA commented Jul 31, 2019

ayodejiAA commented Jul 31, 2019

Choose a reason for hiding this comment

ayodejiAA commented Jul 31, 2019 •

edited

Loading