#161966567 Signup New Users #14

actlikewill · 2019-01-17T21:13:55Z

What does this pull request do?

This pull request creates the Signup Page. It allows a user to create an account for Authors Haven.
using their email and username.

Description of the tasks to be completed?

Creates a sign up page with validation.

How should this be manually tested?

clone the repo https://github.com/andela/ah-technocrats-frontend.git
change to the cloned directory cd ah-technocrats-frontend
git checkout ft-registration-161966567 to checkout to this branch
run npm install to install the application.
run npm start
To log in, Enter your username and email and a password.
The form will validate the entries according to the data provided. The following are the validations present:
- Usernames should be at least five characters
- Passwords should have at least eight characters, one special character and one capital letter.
- None of the fields may be blank.

Screenshots

The form displaying all the errors

The Form after a successful login.

What are the relevant Pivotal Tracker Stories

#161966567

Checklist:

My code follows the style guidelines of this project
At least 2 people have reviewed my PR
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
My PR has one commit.

.codeclimate.yml

dotNesh · 2019-01-21T11:48:10Z

src/reducers/registrationReducer.js

+export default function registrationReducer(state = initialState, action) {
+  switch (action.type) {
+    case types.USER_REGISTRATION_SUBMIT:
+      return Object.assign({}, state, { action: action.registrationData, loading: true });


Use the spread operator instead of Object.assign

Changed to use the spread operator

dotNesh · 2019-01-21T11:51:06Z

src/components/Authentication/Registration/__tests__/RegistrationPage.test.js

+    const wrapper = mount(<BrowserRouter><RegistrationPage {...props} /></BrowserRouter>);
+    const submitButton = wrapper.find('#submit').last();
+    expect(wrapper.find('#submit').exists()).toBe(true);
+    submitButton.simulate('click');


What is being tested here?

I edited the test

dotNesh · 2019-01-21T11:53:28Z

src/components/Authentication/Registration/__tests__/RegistrationPage.test.js

+
+describe('Registration Page class Methods', () => {
+  it('formatUserData Function', () => {
+    const setupProps = Object.assign({}, props, { actions: {}});


Instead of using Object.assign add actions to the props object and pass the props to the component instead.

dotNesh

Good job. Please address the requested changes.

src/components/Authentication/Registration/FormField.jsx

dotNesh

Fix the requested changes

actlikewill · 2019-01-21T14:20:49Z

Fix the requested changes

I have made the requested changes.

salma-nyagaka · 2019-01-21T19:39:07Z

@actlikewill You have not added me and Timothy as your reviewers

actlikewill · 2019-01-22T08:04:29Z

@actlikewill You have not added me and Timothy as your reviewers

Sorry about that ... I have done so now, kindly review

src/App.js

- allows user to create a new account [#161966567]

verenceLola

Nice work @actlikewill

salma-nyagaka

Looks okey and everything is working well

SnyderMbishai

Looks good to me.

actlikewill added the WIP label Jan 17, 2019

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 17, 2019 21:14 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 8759bce to 7177777 Compare January 18, 2019 09:05

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 18, 2019 09:05 Inactive

actlikewill removed the WIP label Jan 18, 2019

actlikewill requested review from SnyderMbishai, salma-nyagaka, dotNesh, SilasKenneth and verenceLola and removed request for SnyderMbishai and salma-nyagaka January 18, 2019 09:05

actlikewill force-pushed the ft-registration-161966567 branch from 7177777 to 5cfc276 Compare January 18, 2019 09:08

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 18, 2019 09:08 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 5cfc276 to cbd62bb Compare January 18, 2019 09:10

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 18, 2019 09:10 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from cbd62bb to 51816e3 Compare January 18, 2019 09:18

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 18, 2019 09:18 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 51816e3 to 3f7429c Compare January 20, 2019 12:41

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 20, 2019 12:41 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 3f7429c to b23e168 Compare January 20, 2019 16:26

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 20, 2019 16:26 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from b23e168 to d6189cf Compare January 21, 2019 11:03

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 21, 2019 11:03 Inactive

dotNesh reviewed Jan 21, 2019

View reviewed changes

.codeclimate.yml Outdated Show resolved Hide resolved

dotNesh reviewed Jan 21, 2019

View reviewed changes

dotNesh suggested changes Jan 21, 2019

View reviewed changes

dotNesh reviewed Jan 21, 2019

View reviewed changes

src/components/Authentication/Registration/FormField.jsx Show resolved Hide resolved

dotNesh suggested changes Jan 21, 2019

View reviewed changes

actlikewill force-pushed the ft-registration-161966567 branch from d6189cf to 8a9a0c5 Compare January 21, 2019 13:28

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 21, 2019 13:28 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 8a9a0c5 to 83332f5 Compare January 21, 2019 13:48

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 21, 2019 13:48 Inactive

actlikewill force-pushed the ft-registration-161966567 branch from 83332f5 to c708800 Compare January 21, 2019 13:56

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 21, 2019 13:56 Inactive

actlikewill requested review from salma-nyagaka and TeamoreA January 22, 2019 08:03

dotNesh reviewed Jan 22, 2019

View reviewed changes

src/App.js Outdated Show resolved Hide resolved

actlikewill force-pushed the ft-registration-161966567 branch from c708800 to 932c343 Compare January 22, 2019 08:16

verenceLola temporarily deployed to ah-techno-staging-pr-14 January 22, 2019 08:16 Inactive

feat(signup) : signup users

2fb3dd5

- allows user to create a new account [#161966567]

actlikewill force-pushed the ft-registration-161966567 branch from 932c343 to 2fb3dd5 Compare January 22, 2019 08:18

verenceLola deployed to ah-techno-staging-pr-14 January 22, 2019 08:18 View deployment

dotNesh approved these changes Jan 22, 2019

View reviewed changes

verenceLola approved these changes Jan 22, 2019

View reviewed changes

salma-nyagaka approved these changes Jan 22, 2019

View reviewed changes

SnyderMbishai approved these changes Jan 22, 2019

View reviewed changes

dotNesh merged commit f2b8c18 into develop Jan 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#161966567 Signup New Users #14

#161966567 Signup New Users #14

actlikewill commented Jan 17, 2019 •

edited

Loading

dotNesh Jan 21, 2019

actlikewill Jan 21, 2019

dotNesh Jan 21, 2019

actlikewill Jan 21, 2019

dotNesh Jan 21, 2019

actlikewill Jan 21, 2019

dotNesh left a comment

dotNesh left a comment

actlikewill commented Jan 21, 2019

salma-nyagaka commented Jan 21, 2019

actlikewill commented Jan 22, 2019

verenceLola left a comment

salma-nyagaka left a comment

SnyderMbishai left a comment

#161966567 Signup New Users #14

#161966567 Signup New Users #14

Conversation

actlikewill commented Jan 17, 2019 • edited Loading

What does this pull request do?

Description of the tasks to be completed?

How should this be manually tested?

Screenshots

What are the relevant Pivotal Tracker Stories

Checklist:

dotNesh Jan 21, 2019

Choose a reason for hiding this comment

actlikewill Jan 21, 2019

Choose a reason for hiding this comment

dotNesh Jan 21, 2019

Choose a reason for hiding this comment

actlikewill Jan 21, 2019

Choose a reason for hiding this comment

dotNesh Jan 21, 2019

Choose a reason for hiding this comment

actlikewill Jan 21, 2019

Choose a reason for hiding this comment

dotNesh left a comment

Choose a reason for hiding this comment

dotNesh left a comment

Choose a reason for hiding this comment

actlikewill commented Jan 21, 2019

salma-nyagaka commented Jan 21, 2019

actlikewill commented Jan 22, 2019

verenceLola left a comment

Choose a reason for hiding this comment

salma-nyagaka left a comment

Choose a reason for hiding this comment

SnyderMbishai left a comment

Choose a reason for hiding this comment

actlikewill commented Jan 17, 2019 •

edited

Loading