#161966583 Search #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actlikewill
changed the title
actlikewill
force-pushed
the
ft-search-161966583
branch
from
36a1051
to
2642651
Compare
actlikewill
force-pushed
the
ft-search-161966583
branch
from
2642651
to
cf2bc9d
Compare
actlikewill
force-pushed
the
ft-search-161966583
branch
from
cf2bc9d
to
61cad64
Compare
actlikewill
force-pushed
the
ft-search-161966583
branch
from
61cad64
to
24bc201
Compare
actlikewill
force-pushed
the
ft-search-161966583
branch
from
24bc201
to
82bdb5c
Compare
actlikewill
force-pushed
the
ft-search-161966583
branch
from
82bdb5c
to
069d493
Compare
actlikewill
requested review from
SnyderMbishai,
salma-nyagaka,
dotNesh,
SilasKenneth,
TeamoreA and
verenceLola
actlikewill
force-pushed
the
ft-search-161966583
branch
from
069d493
to
b8c98fe
Compare
dotNesh
reviewed
Jan 24, 2019
| switch (action.type) { | ||
| case types.SEARCH_SUBMIT: | ||
| return { | ||
| ...state, results: null, keyWords: action.searchKeyWords, loading: true, |
There was a problem hiding this comment.
why is results given the value null?
There was a problem hiding this comment.
That clears the current search page when the user submits a new search.
salma-nyagaka
suggested changes
Jan 25, 2019
actlikewill
force-pushed
the
ft-search-161966583
branch
from
b8c98fe
to
db41ea2
Compare
- allows user to search the articles by author, title or tag [#161966583]t
actlikewill
force-pushed
the
ft-search-161966583
branch
from
db41ea2
to
8ff5981
Compare
salma-nyagaka
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Description of the tasks to be completed?
How should this be manually tested?
clone the repo
https://github.com/andela/ah-technocrats-frontend.gitchange to the cloned directory
cd ah-technocrats-frontendgit checkout t-search-161966583to checkout to this branchrun
npm installto install the application.run npm start
From the search bar, you should be able to enter a search query. Press enter to perfom the search.
What are the relevant Pivotal Tracker Stories
#161966583
Checklist: