Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161966605 signup validation #10

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

salma-nyagaka
Copy link
Contributor

@salma-nyagaka salma-nyagaka commented Dec 4, 2018

What does this PR do?

Adds descriptive validations errors to the registration functionality

Description of Task to be completed?

  • validate email field
  • validate username field
  • validate the password field

How should this be manually tested?

  • git clone https://github.com/andela/ah-technocrats.git
  • cd ah-technocrats
  • git checkout ft-signup-validation-161966605
  • virtualenv venv
  • source venv/bin/activate
  • pip install -r requirements.txt
  • python manage.py makemigrations
  • python manage.py migrate
  • python manage.py runserver

Any background context you want to provide?

Users should receive a descriptive error message when they enter invalid user parameters in an attempt to signup.

What are the relevant pivotal tracker stories?

#161966605

Checklist:

  • My code follows the style guidelines of this project
  • At least 2 people have reviewed my PR
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My PR has one commit.

USERNAME WITH SPACES BETWEEN CHARACTERS
space_between_characters

USERNAME WITH NUMERICALS ONLY
username_only_has_numericals

USERNAME WITH INVALID CHARACTERS
usernamewithinvalidcharacters

SHORT USERNAME
shortusername

USERNAME EXISTS
usernameexists

PASSWORD WITH LETTERS ONLY
passwordwithonlyletters

SHORT PASSWORD
shortassword

PASSWORD WITH NO SPECIAL CHARACTER
passwordwithnospeciacharacter

PASSWORD WITH NUMBERS ONLY
passwordwithonlynumbers

@Mnickii
Copy link

Mnickii commented Dec 4, 2018

The steps in how should this be manually tested
are not sufficient

@salma-nyagaka salma-nyagaka force-pushed the ft-signup-validation-161966605 branch 3 times, most recently from 22273a4 to 549c79c Compare December 4, 2018 14:56
Copy link
Contributor

@SilasKenneth SilasKenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice illustrations with screenshots

@Mnickii
Copy link

Mnickii commented Dec 4, 2018

Fix the failing tests and if done, remove the WIP label.
Very thorough screenshots. Nice!

@salma-nyagaka salma-nyagaka removed the WIP Work In Progress label Dec 4, 2018
- validate email field, username field and password field
- add tests for the sign up functionality
- modify docstrings
- skip the tests that are not required

[Delivers #161966605]
Copy link

@Mnickii Mnickii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@Mnickii Mnickii merged commit b608526 into develop Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants